Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
kohaku: Set GPP_A10 to NC
Setting GPP_A10 to NC now that older boards are deprecated and this GPIO is not in use anymore.
BUG=b:142056166 BRANCH=hatch TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: If8a249a3dcba90bb4ccb5e3f02595e680f789f93 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/kohaku/gpio.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/36869/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 7bf9a0c..fb04332e 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -23,8 +23,9 @@ PAD_NC(GPP_A0, NONE), /* A6 : SERIRQ ==> NC */ PAD_NC(GPP_A6, NONE), - /* A10 : PEN_RESET_ODL for old revision devices */ - PAD_CFG_GPO(GPP_A10, 1, DEEP), + /* A10 : PEN_RESET_ODL for old revision devices + : NC for newer builds (reduce power consumption) */ + PAD_NC(GPP_A10, NONE), /* A16 : EMR_GARAGE_DET (notification) */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), /* A17 : PIRQA# ==> NC */
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... PS1, Line 26: PEN_RESET_ODL for old revision devices nit: Do we still need this comment?
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... PS1, Line 26: PEN_RESET_ODL for old revision devices
nit: Do we still need this comment?
I dunno. I guess I didn't want to remove it if somebody was debugging an old kohaku board. I can remove it if you prefer.
Hello Paul Fagerburg, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36869
to look at the new patch set (#2).
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
kohaku: Set GPP_A10 to NC
Setting GPP_A10 to NC now that older boards are deprecated and this GPIO is not in use anymore.
BUG=b:142056166 BRANCH=hatch TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: If8a249a3dcba90bb4ccb5e3f02595e680f789f93 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/kohaku/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/36869/2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... PS1, Line 26: PEN_RESET_ODL for old revision devices
I dunno. I guess I didn't want to remove it if somebody was debugging an old kohaku board. […]
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kohaku/gpio.c:
https://review.coreboot.org/c/coreboot/+/36869/1/src/mainboard/google/hatch/... PS1, Line 26: PEN_RESET_ODL for old revision devices
I dunno. I guess I didn't want to remove it if somebody was debugging an old kohaku board. […]
Eh no big deal. I just hope to never touch the old one ever again :)
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 2: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36869 )
Change subject: kohaku: Set GPP_A10 to NC ......................................................................
kohaku: Set GPP_A10 to NC
Setting GPP_A10 to NC now that older boards are deprecated and this GPIO is not in use anymore.
BUG=b:142056166 BRANCH=hatch TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: If8a249a3dcba90bb4ccb5e3f02595e680f789f93 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36869 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/kohaku/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/kohaku/gpio.c b/src/mainboard/google/hatch/variants/kohaku/gpio.c index 7bf9a0c..87c586d 100644 --- a/src/mainboard/google/hatch/variants/kohaku/gpio.c +++ b/src/mainboard/google/hatch/variants/kohaku/gpio.c @@ -23,8 +23,8 @@ PAD_NC(GPP_A0, NONE), /* A6 : SERIRQ ==> NC */ PAD_NC(GPP_A6, NONE), - /* A10 : PEN_RESET_ODL for old revision devices */ - PAD_CFG_GPO(GPP_A10, 1, DEEP), + /* A10 : GPP_A10 ==> NC */ + PAD_NC(GPP_A10, NONE), /* A16 : EMR_GARAGE_DET (notification) */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST), /* A17 : PIRQA# ==> NC */
-
Patrick Georgi (Code Review) -
Paul Fagerburg (Code Review)
-
Shelley Chen (Code Review)
-
Tim Wawrzynczak (Code Review)