Change in coreboot[master]: sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45864 )
Change subject: sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax ......................................................................
sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax
Change-Id: Ica6998026031e1b3d7286ce74a2334237d29ac74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl M src/southbridge/amd/pi/hudson/acpi/AmdImc.asl 2 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/45864/1
diff --git a/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl b/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl index e73ccdd..d23fc4f 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl @@ -18,35 +18,35 @@
Method(WACK, 0) { - Store(0, Local0) - Store(50, Local1) - While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) { - Store(MRG0, Local0) + Local0 = 0 + Local1 = 50 + While ((Local0 != 0xFA) && (Local1 > 0)) { + Local0 = MRG0 Sleep(10) - Decrement(Local1) + Local1-- } }
//Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() } diff --git a/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl b/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl index e73ccdd..d23fc4f 100644 --- a/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl +++ b/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl @@ -18,35 +18,35 @@
Method(WACK, 0) { - Store(0, Local0) - Store(50, Local1) - While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) { - Store(MRG0, Local0) + Local0 = 0 + Local1 = 50 + While ((Local0 != 0xFA) && (Local1 > 0)) { + Local0 = MRG0 Sleep(10) - Decrement(Local1) + Local1-- } }
//Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xB5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45864
to look at the new patch set (#3).
Change subject: sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax ......................................................................
sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax
Change-Id: Ica6998026031e1b3d7286ce74a2334237d29ac74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl M src/southbridge/amd/pi/hudson/acpi/AmdImc.asl 2 files changed, 36 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/45864/3
Attention is currently required from: HAOUAS Elyes. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45864 )
Change subject: sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax ......................................................................
Patch Set 3: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45864 )
Change subject: sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax ......................................................................
sb/amd/{agesa,pi}hudson/acpi: Convert 'AmdImc.asl' to ASL 2.0 syntax
Change-Id: Ica6998026031e1b3d7286ce74a2334237d29ac74 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45864 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl M src/southbridge/amd/pi/hudson/acpi/AmdImc.asl 2 files changed, 36 insertions(+), 36 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl b/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl index e73ccdd..757b193 100644 --- a/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl +++ b/src/southbridge/amd/agesa/hudson/acpi/AmdImc.asl @@ -18,35 +18,35 @@
Method(WACK, 0) { - Store(0, Local0) - Store(50, Local1) - While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) { - Store(MRG0, Local0) + Local0 = 0 + Local1 = 50 + While ((Local0 != 0xFA) && (Local1 > 0)) { + Local0 = MRG0 Sleep(10) - Decrement(Local1) + Local1-- } }
//Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() } diff --git a/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl b/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl index e73ccdd..6fe5e33 100644 --- a/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl +++ b/src/southbridge/amd/pi/hudson/acpi/AmdImc.asl @@ -18,35 +18,35 @@
Method(WACK, 0) { - Store(0, Local0) - Store(50, Local1) - While (LAnd (LNotEqual(Local0, 0xFA), LGreater(Local1,0))) { - Store(MRG0, Local0) + Local0 = 0 + Local1 = 50 + While ((Local0 != 0xfa) && (Local1 > 0)) { + Local0 = MRG0 Sleep(10) - Decrement(Local1) + Local1-- } }
//Init Method (ITZE, 0) { - Store(0, MRG0) - Store(0xB5, MRG1) - Store(0, MRG2) - Store(0x96, MSTI) + MRG0 = 0 + MRG1 = 0xb5 + MRG2 = 0 + MSTI = 0x96 WACK()
- Store(0, MRG0) - Store(0, MRG1) - Store(0, MRG2) - Store(0x80, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = 0 + MSTI = 0x80 WACK()
- Or(MRG2, 0x01, Local0) + Local0 = MRG2 | 0x01
- Store(0, MRG0) - Store(0, MRG1) - Store(Local0, MRG2) - Store(0x81, MSTI) + MRG0 = 0 + MRG1 = 0 + MRG2 = Local0 + MSTI = 0x81 WACK() }
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)