Attention is currently required from: Angel Pons, Benjamin Doron, Kapil Porwal, Maulik Vaghela, Patrick Rudolph, Paul Menzel, Sean Rhodes, Subrata Banik, Tarun Tuli, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70377?usp=email )
Change subject: soc/intel: Support NO_SMM on modern SoCs
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/cpu/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/70377/comment/b60c8123_2c6e937b :
PS14, Line 217: *smm_save_state_size = sizeof(em64t101_smm_state_save_area_t);
The codepath for this one is weird. It's a constant for a CPU.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70377?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I94b66020a249714bc4f430de1d1f7808b26261cf
Gerrit-Change-Number: 70377
Gerrit-PatchSet: 14
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Maulik Vaghela
maulikvaghela@google.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 31 Oct 2023 13:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment