Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82664?usp=email )
Change subject: tree: Remove unused <stdarg.h> ......................................................................
tree: Remove unused <stdarg.h>
<stdarg.h> header is used to define macros for handling variable argument lists in functions like printf. It does not depend on the string or memory manipulation functions provided by <string.h>. So let follow conventions and include only the necessary headers in each header file.
Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M src/include/stdarg.h M src/include/string.h M src/soc/amd/common/psp_verstage/psp_verstage.c 3 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/82664/1
diff --git a/src/include/stdarg.h b/src/include/stdarg.h index c5a8cd8..f55fcc3 100644 --- a/src/include/stdarg.h +++ b/src/include/stdarg.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
/** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */
#ifndef STDARG_H diff --git a/src/include/string.h b/src/include/string.h index 92ea5e5..4a06556 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,7 +3,6 @@ #ifndef STRING_H #define STRING_H
-#include <stdarg.h> /* IWYU pragma: export */ #include <stddef.h> #include <stdio.h> /* IWYU pragma: export */
diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c index e71d75a..54945b9 100644 --- a/src/soc/amd/common/psp_verstage/psp_verstage.c +++ b/src/soc/amd/common/psp_verstage/psp_verstage.c @@ -21,7 +21,6 @@ #include <security/vboot/symbols.h> #include <security/vboot/vboot_common.h> #include <arch/stages.h> -#include <stdarg.h> #include <timestamp.h>
extern char _bss_start, _bss_end;