[S] Change in coreboot[main]: soc/amd/common/acpi: Add weak CPPC min/nomimal functions - coreboot-gerrit

5 Dec 2023


      Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79017?usp=email )
Change subject: soc/amd/common/acpi: Add weak CPPC min/nomimal functions
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79017/comment/33e0697b_c072e780 :
PS1, Line 11: allow SoCs not using FSP to use the CPPC common code as well.
...
Having alternative implementations doesn't necessarily require weak […]
Agreed. How do the non-FSP platforms get the values, or do they not need to?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79017?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3cea9b0a8e11aff1949fedbbecba575b351c1706
Gerrit-Change-Number: 79017
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Dec 2023 18:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment