Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47816 )
Change subject: sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs ......................................................................
sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs
These two IDs are for Cougar Point and Panther Point, the previous generation of Platform Controller Hubs. So, drop their device IDs.
Change-Id: I27a58720f32b1cc3eb68c0af2d6819e16c36b954 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/lynxpoint/smbus.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/47816/1
diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index f616473..2741951 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -80,7 +80,7 @@ };
static const unsigned short pci_device_ids[] = { - 0x1c22, 0x1e22, 0x8c22, 0x9c22, + 0x8c22, 0x9c22, 0 };
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47816 )
Change subject: sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47816 )
Change subject: sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47816/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47816/1//COMMIT_MSG@7 PS1, Line 7: invalid Maybe rather `unneeded`? I wouldn't be surprised if it would work and was used in early development.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47816 )
Change subject: sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47816/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47816/1//COMMIT_MSG@7 PS1, Line 7: invalid
Maybe rather `unneeded`? I wouldn't be surprised if it would work […]
Given the rest of the code, I suspect this was a remainder from copy-pasting bd82x6x.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47816 )
Change subject: sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs ......................................................................
sb/intel/lynxpoint/smbus.c: Remove invalid PCI IDs
These two IDs are for Cougar Point and Panther Point, the previous generation of Platform Controller Hubs. So, drop their device IDs.
Change-Id: I27a58720f32b1cc3eb68c0af2d6819e16c36b954 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47816 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/southbridge/intel/lynxpoint/smbus.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index f616473..2741951 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -80,7 +80,7 @@ };
static const unsigned short pci_device_ids[] = { - 0x1c22, 0x1e22, 0x8c22, 0x9c22, + 0x8c22, 0x9c22, 0 };
-
Angel Pons (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)