Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86311?usp=email )
Change subject: mb/google/rauru: Reorder PCIe reset in romstage
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86311/comment/a85736cb_eec37786?usp... :
PS1, Line 7: Reorder PCIe reset in romstage
Deassert PCIe PERST# earlier in romstage
https://review.coreboot.org/c/coreboot/+/86311/comment/ce25d5c9_a8f49e80?usp... :
PS1, Line 9: Reorder the PCIe reset before mtk_dram_init to overlap the de-assert
You didn't mention the reason: reducing boot time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86311?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24b254ff3a3cbe6d9a60a8e6afea2c621e0a07e2
Gerrit-Change-Number: 86311
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 07 Feb 2025 08:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No