Attention is currently required from: Arthur Heymans, Kyösti Mälkki.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64341 )
Change subject: cpu/x86/mp_init.c: Use existing code to create cpu struct device
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Patchset:
PS5:
If a CPU device exists but isn't enabled, using `add_cpu_device()` will enable it. Is this a problem?
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/64341/comment/0f2e4704_cd6186cf
PS5, Line 374: 1);
Ow, this hurts to look at
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80baadd405b31d6be2fdbb894b0f4b7c775da6f8
Gerrit-Change-Number: 64341
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 18:46:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment