Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Elyes Haouas.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69337 )
Change subject: soc/amd: Move "reset.c" to common
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/reset.c:
https://review.coreboot.org/c/coreboot/+/69337/comment/6708053e_8b42ef47
PS1, Line 20: /* Warm resets are not supported and must be executed as cold */
: pm_write16(PWR_RESET_CFG, pm_read16(PWR_RESET_CFG) |
: TOGGLE_ALL_PWR_GOOD);
Is this true for non-cezanne socs?
this file isn't consistent for all socs, so it's probably better to keep it per-soc
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7957c9694300fefb85d11f7819c43af95271f14c
Gerrit-Change-Number: 69337
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 14 Dec 2022 23:39:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-MessageType: comment