Name of user not set #1002723 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37718 )
Change subject: fix that was adviced by Nico Huber ......................................................................
fix that was adviced by Nico Huber
Change-Id: I1e3fc617b915c20fe0cb7cf9e8121bc32b6b574f --- M src/mainboard/dell/dell_system_vostro_3360/Makefile.inc M src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl M src/mainboard/dell/dell_system_vostro_3360/dsdt.asl M src/mainboard/dell/dell_system_vostro_3360/mainboard.c M src/mainboard/dell/dell_system_vostro_3360/romstage.c 5 files changed, 56 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/37718/1
diff --git a/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc b/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc index ebe01ae..05fafb8 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc +++ b/src/mainboard/dell/dell_system_vostro_3360/Makefile.inc @@ -1,2 +1,4 @@ romstage-y += gpio.c +bootblock-y += gpio.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads + diff --git a/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl b/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl index 0222986..a03e76c 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl +++ b/src/mainboard/dell/dell_system_vostro_3360/acpi/platform.asl @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + Method(_WAK,1) { Return(Package(){0,0}) diff --git a/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl b/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl index c7b42e0..6fdaad0 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl +++ b/src/mainboard/dell/dell_system_vostro_3360/dsdt.asl @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB #define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0 @@ -15,10 +32,10 @@ /* Some generic macros */ #include "acpi/platform.asl" #include <cpu/intel/common/acpi/cpu.asl> - #include <southbridge/intel/bd82x6x/acpi/platform.asl> + #include <southbridge/intel/common/acpi/platform.asl> /* global NVS and variables. */ #include <southbridge/intel/bd82x6x/acpi/globalnvs.asl> - #include <southbridge/intel/bd82x6x/acpi/sleepstates.asl> + #include <southbridge/intel/common/acpi/sleepstates.asl>
Device (_SB.PCI0) { diff --git a/src/mainboard/dell/dell_system_vostro_3360/mainboard.c b/src/mainboard/dell/dell_system_vostro_3360/mainboard.c index 1f96d9e..1136015 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/mainboard.c +++ b/src/mainboard/dell/dell_system_vostro_3360/mainboard.c @@ -1,3 +1,20 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2008-2009 coresystems GmbH + * Copyright (C) 2014 Vladimir Serbinenko + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; version 2 of + * the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + #include <device/device.h> #include <drivers/intel/gma/int15.h> #include <southbridge/intel/bd82x6x/pch.h> diff --git a/src/mainboard/dell/dell_system_vostro_3360/romstage.c b/src/mainboard/dell/dell_system_vostro_3360/romstage.c index a090ab6..0496764 100644 --- a/src/mainboard/dell/dell_system_vostro_3360/romstage.c +++ b/src/mainboard/dell/dell_system_vostro_3360/romstage.c @@ -30,16 +30,12 @@ #include <southbridge/intel/bd82x6x/pch.h> #include <southbridge/intel/common/gpio.h>
-void pch_enable_lpc(void) +void mainboard_pch_lpc_setup(void) { pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); }
-void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 1, 0 }, { 1, 1, 0 }, @@ -57,14 +53,6 @@ { 0, 1, 6 }, };
-void mainboard_early_init(int s3resume) -{ -} - -void mainboard_config_superio(void) -{ -} - /* FIXME: Put proper SPD map here. */ void mainboard_get_spd(spd_raw_data *spd, bool id_only) {
Name of user not set #1002723 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37718 )
Change subject: fix that was adviced by Nico Huber ......................................................................
Patch Set 1:
Patch Set 1:
Hi, I see that this code is scattered around various changes on Gerrit. I would recommend keeping things simple: only have a single change that is the mainboard port, which corresponds to a single commit on your local tree.
Gerrit uses the Change-Id line on the commit message to identify changes. When pushing commits, Gerrit looks at the Change-Id. If it already exists on an existing change, then the commit is considered to be an update of that change. Otherwise, it is considered a new change.
The idea is to always use the same Change-Id. If you want to modify something of that commit, just use `git commit --amend`. That way, when you push it to Gerrit, it will show as another patchset of the same change.
Hi, okok. I will pay attention to it next time I'll push something
-
Name of user not set (Code Review)