Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Krishna P Bhat D. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61141 )
Change subject: mb/google/nissa: Add devicetree ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/61141/comment/15e518fb_8bdc3118 PS5, Line 34: " Should we also configure the AUX DC bias pads here:
``` register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}" register "typec_aux_bias_pads[1]" = "{.pad_auxp_dc = GPP_A21, .pad_auxn_dc = GPP_A22}" ```
IIUC, this is needed for Type-C ports which don't have a retimer. On brya, most ports do, so it's configured per-variant. But on nissa, I assume most boards won't use retimers (right?), so should we configure it in the baseboard?
-
Reka Norman (Code Review)