Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6139
-gerrit
commit ca1e65baf642b6a6772f93fc82065967c32c09f5 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Fri Jun 27 18:07:05 2014 +1000
utils/cbfstool: No need to pass -g flag twice
Spotted by building with Clang.
Change-Id: I7ab97278d8bd586a71e453c8cc9d26dd6938c8d2 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- util/cbfstool/Makefile | 1 - util/cbfstool/Makefile.inc | 3 --- 2 files changed, 4 deletions(-)
diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile index e647c88..4f282f9 100644 --- a/util/cbfstool/Makefile +++ b/util/cbfstool/Makefile @@ -6,7 +6,6 @@ CFLAGS += -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS += -Wwrite-strings -Wredundant-decls -Wno-trigraphs CFLAGS += -Wstrict-aliasing -Werror CFLAGS += -Wshadow -LDFLAGS += -g
CBFSTOOL_BINARY:=$(obj)/cbfstool
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 2923938..0548ea4 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -23,8 +23,6 @@ rmodobj += common.o rmodobj += elfheaders.o rmodobj += xdr.o
-TOOLFLAGS= -g - ifeq ($(shell uname -s | cut -c-7 2>/dev/null), MINGW32) TOOLFLAGS+=-mno-ms-bitfields endif @@ -51,4 +49,3 @@ $(objutil)/cbfstool/cbfstool: $(objutil)/cbfstool $(addprefix $(objutil)/cbfstoo $(objutil)/cbfstool/rmodtool: $(objutil)/cbfstool $(addprefix $(objutil)/cbfstool/,$(rmodobj)) printf " HOSTCC $(subst $(objutil)/,,$(@)) (link)\n" $(HOSTCC) $(TOOLFLAGS) -o $@ $(addprefix $(objutil)/cbfstool/,$(rmodobj)) -