Change in ...coreboot[master]: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 )

Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31250/3/src/soc/intel/cannonlake/chip.c 
File src/soc/intel/cannonlake/chip.c:

https://review.coreboot.org/#/c/31250/3/src/soc/intel/cannonlake/chip.c@159 
PS3, Line 159: PCH_H
> I see you said it isn't needed, but is there a downside to enabling?

Actually, gpio.c is kind of separate for PCH-H and I did not want to duplicate the code (in the hope that FSP will get fixed pretty soon). But, since we are not sure of the timeline, its probably better to just do it unconditionally. I have moved cnl_configure_pads to chip.c.