Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54912 )
Change subject: mb/google/brya: Configure WWAN GPIO early
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/54912/comment/267e4747_0d483dae
PS2, Line 396: DEEP
There is an external PD on WWAN_PERST_L - R331. […]
actually I have tested this on L850 module and I dont see issue in warm reboot cycle even after removing PERST from early GPIOs, Eric suggested to add it for FM350 module, I dont have FM350 module 😞
Eric, can you please give this a try with FM350 with the suggested changes ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54912
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6d69696b6c645eec3fa314a608c69214bafba82
Gerrit-Change-Number: 54912
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 27 May 2021 04:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment