build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28661 )
Change subject: soc/intel/cannonlake: Move the FSP related callbacks to separate files
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params....
PS3, Line 82: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) {
braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/28661/3/src/soc/intel/cannonlake/fsp_params....
PS3, Line 86: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/28661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffadc57f6986e688aa1bbe4e5444d105386ad92e
Gerrit-Change-Number: 28661
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Naresh Solanki
naresh.solanki@intel.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 25 Sep 2018 04:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No