Attention is currently required from: Felix Singer, Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60992 )
Change subject: soc/intel/denverton_ns: enable Denverton to use common SoC XHCI code
......................................................................
Patch Set 10:
(1 comment)
File src/soc/intel/denverton_ns/chip.h:
https://review.coreboot.org/c/coreboot/+/60992/comment/c14b4b58_eee05719
PS10, Line 6: #include <acpi/acpi_device.h>
please, why this include ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I505b3a7761cb3719697626e1f272d0928fdd29f1
Gerrit-Change-Number: 60992
Gerrit-PatchSet: 10
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Mar 2022 21:32:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment