Change in coreboot[master]: commonlib/lz4_wrapper.c: do not use bitfields - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Krystian Hebel.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55040 )
Change subject: commonlib/lz4_wrapper.c: do not use bitfields
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS3: 
It's really frustrating that GCC doesn't just offer an option to control this ordering somehow, but I guess we're stuck with doing it like this.
File src/commonlib/bsd/lz4_wrapper.c:
https://review.coreboot.org/c/coreboot/+/55040/comment/5efeebc3_2f104d27 
PS3, Line 129: lz4_block_header
nit: don't think there's much of a point in having this type anymore now, could just use a raw uint32_t
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief7d87ddb25c9baa931f27dbd54a4ca730b6ece7
Gerrit-Change-Number: 55040
Gerrit-PatchSet: 3
Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Tue, 01 Jun 2021 23:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment