Attention is currently required from: Martin Roth, Stefan Reinauer, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52191 )
Change subject: payloads/tianocore: Fix compilation for UEFIPAYLOAD option
......................................................................
Patch Set 1:
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/52191/comment/767c0baf_756c9f36
PS1, Line 49: ARCH=-a IA32 -a X64 -p UefiPayloadPkg/UefiPayloadPkg.dsc
I'd add a `dsc_file` variable that gets set accordingly for CorebootPayloadPkg and UefiPayloadPkg
but that's arch dependent, and what does setting another variable really accomplish when it's only used one place?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40077f1d370f0cb5627645b305b57e6c71e44095
Gerrit-Change-Number: 52191
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 14:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment