Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55945 )
Change subject: drivers/intel/usb4/retimer: Update code to assign correct port number ......................................................................
Patch Set 8:
(5 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123283): https://review.coreboot.org/c/coreboot/+/55945/comment/8e328fd5_be7ffd6b PS8, Line 359: printk(BIOS_ERR,"%s: No DFP%1d power GPIO for %s\n", __func__, dfp_port, space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123283): https://review.coreboot.org/c/coreboot/+/55945/comment/f625fd3f_26633e65 PS8, Line 360: dev_path(dev)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123283): https://review.coreboot.org/c/coreboot/+/55945/comment/d2cdc93f_735f9046 PS8, Line 360: dev_path(dev)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123283): https://review.coreboot.org/c/coreboot/+/55945/comment/0cad8315_29852c75 PS8, Line 379: printk(BIOS_ERR,"Error retrieving PLD for USB Type-C %d\n", usb_port); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123283): https://review.coreboot.org/c/coreboot/+/55945/comment/14e17bb9_89a90961 PS8, Line 379: printk(BIOS_ERR,"Error retrieving PLD for USB Type-C %d\n", usb_port); space required after that ',' (ctx:VxV)