Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62574 )
Change subject: cbfstool/linux_trampoline: Fill the ACPI RSDP entry ......................................................................
Patch Set 1:
(15 comments)
File util/cbfstool/linux_trampoline.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/78ef916b_70c38093 PS1, Line 6: 0xcb, 0x0f, 0x84, 0xc3, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/aeb15b3e_c5fb258d PS1, Line 6: 0xcb, 0x0f, 0x84, 0xc3, 0x00, 0x00, 0x00, 0x8b, 0x59, 0x04, 0x01, 0xcb, 0x8b, 0x49, 0x14, 0x83, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/57c028ec_e256def1 PS1, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2d, 0x83, 0x7f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/72c119c2_54a0034c PS1, Line 11: 0xe8, 0x01, 0x09, 0x00, 0xbf, 0xd0, 0x02, 0x09, 0x00, 0x83, 0xf8, 0x00, 0x74, 0x2d, 0x83, 0x7f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/f2d12064_2870690e PS1, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x10, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/0a4e64d5_631fae89 PS1, Line 13: 0xe8, 0x83, 0x3b, 0x43, 0x75, 0x10, 0x8b, 0x43, 0x08, 0xa3, 0x70, 0x00, 0x09, 0x00, 0x8b, 0x43, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/a1b352ff_86740266 PS1, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x0f, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/b847269d_d3b30e87 PS1, Line 14: 0x0c, 0xa3, 0x74, 0x00, 0x09, 0x00, 0x83, 0x3b, 0x12, 0x75, 0x00, 0x03, 0x5b, 0x04, 0x49, 0x0f, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/6f93658d_7568ac69 PS1, Line 15: 0x85, 0x7a, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, 0xff, 0x00, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/9b5f96e9_2a8f2354 PS1, Line 15: 0x85, 0x7a, 0xff, 0xff, 0xff, 0xb8, 0x00, 0x00, 0x04, 0x00, 0xc7, 0x40, 0x10, 0xff, 0xff, 0x00, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/060e551c_131fbbaa PS1, Line 16: 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/88054008_d03bcb6c PS1, Line 16: 0x00, 0xc7, 0x40, 0x14, 0x00, 0x9b, 0xcf, 0x00, 0xc7, 0x40, 0x18, 0xff, 0xff, 0x00, 0x00, 0xc7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/17ddc381_cfcc2a13 PS1, Line 17: 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, 0x10, 0xbe, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/23568865_e753b138 PS1, Line 17: 0x40, 0x1c, 0x00, 0x93, 0xcf, 0x00, 0xc6, 0x00, 0x2b, 0x89, 0x40, 0x02, 0x0f, 0x01, 0x10, 0xbe, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143059): https://review.coreboot.org/c/coreboot/+/62574/comment/7dc3ee34_e95df07f PS1, Line 18: 0x00, 0x00, 0x09, 0x00, 0xff, 0x25, 0x14, 0x02, 0x09, 0x00, 0xf4, 0xeb, 0xfd please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)