Change in coreboot[master]: Makefile.inc: Move adding bootblock non-x86 targets - coreboot-gerrit

4 Apr 2022


      Attention is currently required from: Arthur Heymans.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63217 )
Change subject: Makefile.inc: Move adding bootblock non-x86 targets
......................................................................
Patch Set 5:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63217/comment/bb48e5fc_debfb65f 
PS5, Line 1161: ifneq ($(CONFIG_ARCH_X86),y)
Shouldn't this be part of a target or something?  Right now it looks like it's just a bare part of the makefile that will get run when the makefile is sourced regardless of what target is being run.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63217
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50eae4f00d171d26a221ca969086f4f294fa524b
Gerrit-Change-Number: 63217
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 04 Apr 2022 18:17:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment