Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32259
Change subject: mb/google/sarien/arcada: modify some gpio as NC ......................................................................
mb/google/sarien/arcada: modify some gpio as NC
modify following gipo as NC. /* GSPI0_MISO */ PAD_NC(GPP_B17, NONE), /* I2C5_SDA */ PAD_NC(GPP_H10, NONE), /* I2C5_SCL */ PAD_NC(GPP_H11, NONE),
BUG=b:129990365 TEST=build image pass
Change-Id: Iaf751ec82ff74b2b97a7d8141db59236778712c7 --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32259/1
diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c index 1b06301..9ede492 100644 --- a/src/mainboard/google/sarien/variants/arcada/gpio.c +++ b/src/mainboard/google/sarien/variants/arcada/gpio.c @@ -71,7 +71,7 @@ /* SPKR */ PAD_CFG_NF(GPP_B14, NONE, DEEP, NF1), /* GSPI0_CS# */ PAD_NC(GPP_B15, NONE), /* PRIM_CORE_OPT_DIS (nostuff) */ /* GSPI0_CLK */ PAD_CFG_GPI(GPP_B16, NONE, DEEP), /* ONE_DIMM# */ -/* GSPI0_MISO */ PAD_CFG_GPI(GPP_B17, NONE, DEEP), /* RTC_DET# */ +/* GSPI0_MISO */ PAD_NC(GPP_B17, NONE), /* RTC_DET# */ /* GSPI0_MOSI */ PAD_NC(GPP_B18, NONE), /* GSPI1_CS# */ PAD_NC(GPP_B19, NONE), /* HDD_FALL_INT (nostuff) */ /* GSPI1_CLK */ PAD_NC(GPP_B20, NONE), /* TPM_PIRQ# (nostuff) */ @@ -209,8 +209,8 @@ /* I2C3_SCL */ PAD_NC(GPP_H7, NONE), /* I2C4_SDA */ PAD_CFG_NF(GPP_H8, NONE, DEEP, NF1), /* I2C_SDA_H1 */ /* I2C4_SCL */ PAD_CFG_NF(GPP_H9, NONE, DEEP, NF1), /* I2C_SCL_H1 */ -/* I2C5_SDA */ PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* ISH_I2C2_SDA */ -/* I2C5_SCL */ PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), /* ISH_I2C2_SCL */ +/* I2C5_SDA */ PAD_NC(GPP_H10, NONE), /* ISH_I2C2_SDA */ +/* I2C5_SCL */ PAD_NC(GPP_H11, NONE), /* ISH_I2C2_SCL */ /* M2_SKT2_CFG0 */ PAD_NC(GPP_H12, NONE), /* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE), /* M2_SKT2_CFG2 */ PAD_NC(GPP_H14, NONE),
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32259
to look at the new patch set (#2).
Change subject: mb/google/sarien/arcada: modify some gpio as NC ......................................................................
mb/google/sarien/arcada: modify some gpio as NC
modify following gipo as NC. /* GSPI0_MISO */ PAD_NC(GPP_B17, NONE), /* I2C5_SDA */ PAD_NC(GPP_H10, NONE), /* I2C5_SCL */ PAD_NC(GPP_H11, NONE),
BUG=b:129990365 TEST=build image pass
Change-Id: Iaf751ec82ff74b2b97a7d8141db59236778712c7 Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32259/2
Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32259
to look at the new patch set (#3).
Change subject: mb/google/sarien/arcada: modify some gpio as NC ......................................................................
mb/google/sarien/arcada: modify some gpio as NC
modify following gipo as NC. /* GSPI0_MISO */ PAD_NC(GPP_B17, NONE), /* I2C5_SDA */ PAD_NC(GPP_H10, NONE), /* I2C5_SCL */ PAD_NC(GPP_H11, NONE),
BUG=b:129990365 TEST=build image pass
Change-Id: Iaf751ec82ff74b2b97a7d8141db59236778712c7 Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32259/3
Casper Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32259 )
Change subject: mb/google/sarien/arcada: modify some gpio as NC ......................................................................
Abandoned
Abandon due to same change is under reviewing
Todd Broch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32259 )
Change subject: mb/google/sarien/arcada: modify some gpio as NC ......................................................................
Patch Set 3:
Other CL was here: https://review.coreboot.org/c/coreboot/+/32164
-
Casper Chang (Code Review) -
Todd Broch (Code Review)