Change in coreboot[master]: soc/mediatek/mt8183: [DONOT MERGE]force DO DRAM full calibration each...

[huayang duan (Code Review)]

Hello Duan huayang,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39817

to review the following change.

Change subject: soc/mediatek/mt8183: [DONOT MERGE]force DO DRAM full calibration each times[DONOT MERGE]
......................................................................

soc/mediatek/mt8183: [DONOT MERGE]force DO DRAM full calibration each times[DONOT MERGE]

this patch only can used for new DDR QVL, DONOT MERGE!

DONOT MERGE!

DONOT MERGE!

Change-Id: I75fb731c4f8dc9d5fe3618c73feabeeeb44baa39
Signed-off-by: Huayang Duan 
---
M src/soc/mediatek/mt8183/memory.c
1 file changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/39817/1

diff --git a/src/soc/mediatek/mt8183/memory.c b/src/soc/mediatek/mt8183/memory.c
index 15ae9cb..285ce7d 100644
--- a/src/soc/mediatek/mt8183/memory.c
+++ b/src/soc/mediatek/mt8183/memory.c
@@ -172,6 +172,8 @@
    if (CONFIG(MT8183_DRAM_DVFS) && !recovery_mode)
    	config |= DRAMC_CONFIG_DVFS;

+// disable fast calibration for DO DRAM full calibration each times
+if (0) {
    /* Load calibration params from flash and run fast calibration */
    if (recovery_mode) {
    	printk(BIOS_WARNING, "Skip loading cached calibration data\n");
@@ -197,12 +199,15 @@
    	printk(BIOS_WARNING,
    	       "Failed to read calibration data from flash\n");
    }
+}

+// force DO DRAM full calibration each times
+if (1) {
    /* Run full calibration */
-	printk(BIOS_INFO, "DRAM-K: Full Calibration\n");
+	printk(BIOS_ERR, "DRAM-K: Full Calibration for new DDR QVL test (Qualified Vendor List)\n");
    int err = dram_run_full_calibration(dparam, config);
    if (err == 0) {
-		printk(BIOS_INFO, "Successfully loaded DRAM blobs and "
+		printk(BIOS_ERR, "Successfully loaded DRAM blobs and "
    	       "ran DRAM calibration\n");

/*
@@ -222,6 +227,7 @@

printk(BIOS_ERR, "Failed to do full calibration (%d), "
           "falling back to load default sdram param\n", err);
+}

/* Init params from sdram configs and run partial calibration */
    printk(BIOS_INFO, "DRAM-K: Partial Calibration\n");

[Duan huayang (Code Review)]

Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39817 )

Change subject: soc/mediatek/mt8183: [DONOT MERGE]force DO DRAM full calibration each times[DONOT MERGE]
......................................................................

Patch Set 1: Code-Review-1

[huayang duan (Code Review)]

huayang duan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39817 )

Change subject: soc/mediatek/mt8183: [DONOT MERGE]force DO DRAM full calibration each times[DONOT MERGE]
......................................................................

Abandoned

have submit new patch replace it.
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/b...