Change in coreboot[master]: libpayload/lpgcc: Check for `libpayload.config` for in-tree builds
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48938 )
Change subject: libpayload/lpgcc: Check for `libpayload.config` for in-tree builds ......................................................................
libpayload/lpgcc: Check for `libpayload.config` for in-tree builds
Instead of checking for an already fully build `libpayload.a`, we check for the `libpayload.config` which is the actual prerequisite to start using `lpgcc`. This will allow compilation of payload sources before or in parallel with the build of `libpayload.a`.
Change-Id: Ic0143fefe33560af8b013ae48bbbe231b3ad46f3 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/libpayload/bin/lp.functions 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/48938/1
diff --git a/payloads/libpayload/bin/lp.functions b/payloads/libpayload/bin/lp.functions index 8d784eb..fd26956 100644 --- a/payloads/libpayload/bin/lp.functions +++ b/payloads/libpayload/bin/lp.functions @@ -52,7 +52,7 @@
if [ -f $BASE/../lib/libpayload.a ]; then _LIBDIR=$BASE/../lib -elif [ -f $_OBJ/libpayload.a ]; then +elif [ -f $_OBJ/libpayload.config ]; then _LIBDIR=$_OBJ else _LIBDIR=$LIBPAYLOAD_PREFIX/lib
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48938 )
Change subject: libpayload/lpgcc: Check for `libpayload.config` for in-tree builds ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48938 )
Change subject: libpayload/lpgcc: Check for `libpayload.config` for in-tree builds ......................................................................
libpayload/lpgcc: Check for `libpayload.config` for in-tree builds
Instead of checking for an already fully build `libpayload.a`, we check for the `libpayload.config` which is the actual prerequisite to start using `lpgcc`. This will allow compilation of payload sources before or in parallel with the build of `libpayload.a`.
Change-Id: Ic0143fefe33560af8b013ae48bbbe231b3ad46f3 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48938 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org --- M payloads/libpayload/bin/lp.functions 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/payloads/libpayload/bin/lp.functions b/payloads/libpayload/bin/lp.functions index 8d784eb..fd26956 100644 --- a/payloads/libpayload/bin/lp.functions +++ b/payloads/libpayload/bin/lp.functions @@ -52,7 +52,7 @@
if [ -f $BASE/../lib/libpayload.a ]; then _LIBDIR=$BASE/../lib -elif [ -f $_OBJ/libpayload.a ]; then +elif [ -f $_OBJ/libpayload.config ]; then _LIBDIR=$_OBJ else _LIBDIR=$LIBPAYLOAD_PREFIX/lib
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48938 )
Change subject: libpayload/lpgcc: Check for `libpayload.config` for in-tree builds ......................................................................
Patch Set 2:
Thanks for the reviews, Raul!
-
Nico Huber (Code Review) -
Raul Rangel (Code Review)