Change in coreboot[master]: soc/amd/common/block/psp: factor out soc_get_psp_base_address

[Martin Roth (Code Review)]

Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50447 )

Change subject: soc/amd/common/block/psp: factor out soc_get_psp_base_address
......................................................................

Patch Set 2:

(1 comment)

File src/soc/amd/common/block/psp/psp_gen2.c:

https://review.coreboot.org/c/coreboot/+/50447/comment/bedcfa21_6f7a12f5 
PS2, Line 16: psp_mmio
> no. see how the return value is handled in send_psp_command(). […]

Not really related to this bug, but I think we should really try to avoid die() in general.  If there's really no way to continue, sure.  Otherwise, my opinion is that we should just try to limp along.

The issue is that generally when we die, if there's no serial output, we're just left with an unresponsive board.

Maybe we need a "die_later()" command that prints errors to the screen and halts the system.  This would be perfect for things like security issues.