Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32359
Change subject: mb/google/poppy/variants/atlas: Revise AC/DC loadline ......................................................................
mb/google/poppy/variants/atlas: Revise AC/DC loadline
This patch revises the AC/DC loadline settings because some major layout changes between proto and evt boards.
BUG=b:130740639 BRANCH=None TEST=emerge-atlas coreboot chromeos-bootimage and boot to the OS.
Change-Id: Iea12c621e7fab427a0de8f43f0290bf01d0c5a09 Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/32359/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 53af87d..ad79bca 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -88,8 +88,8 @@ #| ImonOffset | 0 | 0 | 0 | 0 | #| IccMax | set by SoC code per CPU SKU | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | - #| AcLoadline | 14.75 | 4.42 | 4.7 | 4.7 | - #| DcLoadline | 14.2 | 4.2 | 4.41 | 4.41 | + #| AcLoadline | 16.20 | 5.24 | 4.62 | 4.62 | + #| DcLoadline | 14.2 | 4.94 | 4.25 | 4.25 | #+----------------+-------+-------+-------+-------+ register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ .vr_config_enable = 1, @@ -101,7 +101,7 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 1475, + .ac_loadline = 1620, .dc_loadline = 1420, }"
@@ -115,8 +115,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 442, - .dc_loadline = 420, + .ac_loadline = 524, + .dc_loadline = 494, }"
register "domain_vr_config[VR_GT_UNSLICED]" = "{ @@ -129,8 +129,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 470, - .dc_loadline = 441, + .ac_loadline = 462, + .dc_loadline = 425, }"
register "domain_vr_config[VR_GT_SLICED]" = "{ @@ -143,8 +143,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 470, - .dc_loadline = 441, + .ac_loadline = 462, + .dc_loadline = 425, }"
# PCIe Root port 1 with SRCCLKREQ1# (WLAN)
caveh jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32359 )
Change subject: mb/google/poppy/variants/atlas: Revise AC/DC loadline ......................................................................
Patch Set 1: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32359 )
Change subject: mb/google/poppy/variants/atlas: Revise AC/DC loadline ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32359 )
Change subject: mb/google/poppy/variants/atlas: Revise AC/DC loadline ......................................................................
mb/google/poppy/variants/atlas: Revise AC/DC loadline
This patch revises the AC/DC loadline settings because some major layout changes between proto and evt boards.
BUG=b:130740639 BRANCH=None TEST=emerge-atlas coreboot chromeos-bootimage and boot to the OS.
Change-Id: Iea12c621e7fab427a0de8f43f0290bf01d0c5a09 Signed-off-by: Gaggery Tsai gaggery.tsai@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32359 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: caveh jalali caveh@chromium.org Reviewed-by: Caveh Jalali caveh@google.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb 1 file changed, 9 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved caveh jalali: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb index 53af87d..ad79bca 100644 --- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb +++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb @@ -88,8 +88,8 @@ #| ImonOffset | 0 | 0 | 0 | 0 | #| IccMax | set by SoC code per CPU SKU | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | - #| AcLoadline | 14.75 | 4.42 | 4.7 | 4.7 | - #| DcLoadline | 14.2 | 4.2 | 4.41 | 4.41 | + #| AcLoadline | 16.20 | 5.24 | 4.62 | 4.62 | + #| DcLoadline | 14.2 | 4.94 | 4.25 | 4.25 | #+----------------+-------+-------+-------+-------+ register "domain_vr_config[VR_SYSTEM_AGENT]" = "{ .vr_config_enable = 1, @@ -101,7 +101,7 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 1475, + .ac_loadline = 1620, .dc_loadline = 1420, }"
@@ -115,8 +115,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 442, - .dc_loadline = 420, + .ac_loadline = 524, + .dc_loadline = 494, }"
register "domain_vr_config[VR_GT_UNSLICED]" = "{ @@ -129,8 +129,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 470, - .dc_loadline = 441, + .ac_loadline = 462, + .dc_loadline = 425, }"
register "domain_vr_config[VR_GT_SLICED]" = "{ @@ -143,8 +143,8 @@ .imon_slope = 0x0, .imon_offset = 0x0, .voltage_limit = 1520, - .ac_loadline = 470, - .dc_loadline = 441, + .ac_loadline = 462, + .dc_loadline = 425, }"
# PCIe Root port 1 with SRCCLKREQ1# (WLAN)
-
Caveh Jalali (Code Review) -
caveh jalali (Code Review)
-
Gaggery Tsai (Code Review)
-
Patrick Georgi (Code Review)