Attention is currently required from: Maulik V Vaghela, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port
......................................................................
Patch Set 14: Code-Review+2
(3 comments)
Patchset:
PS14:
Eventually I have some thoughts about moving this into devicetree, but this will work for now thanks Maulik! 😊
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/1855dc2a_562e1a5d
PS14, Line 4: #include <drivers/intel/usb4/retimer/retimer.h>
nit: should include <device/device.h> for `is_dev_enabled`
https://review.coreboot.org/c/coreboot/+/59666/comment/afd884c5_9c233aa4
PS14, Line 6: #include <string.h>
nit: is this required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3735b7c7794b46123aba3beac8c0268ce72d658c
Gerrit-Change-Number: 59666
Gerrit-PatchSet: 14
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 06 Dec 2021 23:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment