Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Simon Glass.
Felix Held has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
We did discuss the various configuration mechanisms available... […]
when using fmap, you'll have the start and size of all sections as defines in a generated header file, so those are a fixed locations. with using this you have the ease of use of a fixed flash offset in the code and not need to walk some data structure while using already existing and proven coreboot infrastructure instead of adding some hack.
have a look at build/fmap_config.h after running a build; i'm rather sure that that should exactly provide what you need. only thing to make sure is that the corresponding fmap partition is inside of the part of the flash that gets mmio-mapped without much additional setup.
when there's some infrastructure that can easily do what's needed, i'm rather strongly opposed to reinventing the wheel
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 27 Jun 2024 17:39:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Simon Glass
sjg@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de