Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/18995 )
Change subject: siemens/mc_apl1: Adjust gpio settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/18995/2/src/mainboard/siemens/mc_apl1/brd_gp...
File src/mainboard/siemens/mc_apl1/brd_gpio.h:
Line 20: * entries for each table. */
As this is a multi-line comment outside a function, please use the elaborat
Yes of course, you are right. Thanks Paul!
--
To view, visit
https://review.coreboot.org/18995
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f440e863c2e6f59298c500ac5aefa3b7386bcdf
Gerrit-PatchSet: 2
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes