Attention is currently required from: Jan Philipp Groß, Máté Kukri.
Felix Singer has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82760?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell) ......................................................................
Patch Set 15: Code-Review+2
(3 comments)
Patchset:
PS15: Just a few nits. Otherwise looks good to me!
File src/mainboard/asrock/z97e-itx_ac/Kconfig:
https://review.coreboot.org/c/coreboot/+/82760/comment/f05b97da_ea748228?usp... : PS15, Line 1: ## SPDX-License-Identifier: GPL-2.0-or-later Add blank line here.
File src/mainboard/asrock/z97e-itx_ac/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/82760/comment/8cd95ca6_5afb633c?usp... : PS15, Line 18: /* global NVS and variables. */ Seems superfluous. Please remove.