Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65087 )
Change subject: common: Begin Tiger Lake integration ......................................................................
Patch Set 9:
(8 comments)
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/93a51bf1_8ccdeea9 PS8, Line 38: =>
Please align up.
Done
https://review.coreboot.org/c/libgfxinit/+/65087/comment/f8bcc490_f8d0f0d5 PS8, Line 186: hswsklbool
I supposse this and the next are `hswskltglbool` as well then.
Oops yes
https://review.coreboot.org/c/libgfxinit/+/65087/comment/7f572ee4_be3d6ab9 PS8, Line 327: tglhswvar
I think this one should stay `hswvar`. Meaning, if the generation is Haswell, […]
Ack
https://review.coreboot.org/c/libgfxinit/+/65087/comment/b0612919_ec44af9e PS8, Line 504: function Is_Tiger_Lake (Device_Id : Word16) return Boolean is : (Is_Tiger_Lake_U (Device_Id) or Is_Tiger_Lake_H (Device_Id));
Do we need this function?
Ack
https://review.coreboot.org/c/libgfxinit/+/65087/comment/d62344f4_9db2e4d0 PS8, Line 545: Is_Tiger_Lake_U (Device_Id)));
No tabs, please.
Done
File common/hw-gfx-gma-config_helpers.adb:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/3a0ef489_aad3bdcd PS8, Line 53: ????
You couldn't test or you are unsure or... […]
Leftover from when I wasn't sure
File common/hw-gfx-gma.adb:
https://review.coreboot.org/c/libgfxinit/+/65087/comment/b6defd66_65953e05 PS8, Line 58:
A little spurious indentation
Done
https://review.coreboot.org/c/libgfxinit/+/65087/comment/39612197_a0409b49 PS8, Line 59: =>
Please align up
Done
-
Tim Wawrzynczak (Code Review)