HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43955 )
Change subject: src/include: Add missing <stdbool.h> ......................................................................
src/include: Add missing <stdbool.h>
Include <types.h> when stddef, stdint and stdbool are needed.
Change-Id: I31234b282b89ef1c5ebfe1693bf7f715be527a7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi_pld.h M src/include/device/hypertransport_def.h M src/include/espi.h M src/include/fit.h M src/include/program_loading.h M src/include/spd_cache.h 6 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43955/1
diff --git a/src/include/acpi/acpi_pld.h b/src/include/acpi/acpi_pld.h index 5a7663c..e347834 100644 --- a/src/include/acpi/acpi_pld.h +++ b/src/include/acpi/acpi_pld.h @@ -4,6 +4,7 @@ #define __ACPI_ACPI_PLD_H__
#include <acpi/acpi.h> +#include <stdbool.h> #include <stdint.h>
enum acpi_pld_panel { diff --git a/src/include/device/hypertransport_def.h b/src/include/device/hypertransport_def.h index a0b1a36..bed7fea 100644 --- a/src/include/device/hypertransport_def.h +++ b/src/include/device/hypertransport_def.h @@ -1,6 +1,8 @@ #ifndef DEVICE_HYPERTRANSPORT_DEF_H #define DEVICE_HYPERTRANSPORT_DEF_H
+#include <stdbool.h> + #define HT_FREQ_200Mhz 0 #define HT_FREQ_300Mhz 1 #define HT_FREQ_400Mhz 2 diff --git a/src/include/espi.h b/src/include/espi.h index 4be8543..2dec646 100644 --- a/src/include/espi.h +++ b/src/include/espi.h @@ -3,6 +3,7 @@ #ifndef __ESPI_H__ #define __ESPI_H__
+#include <stdbool.h> #include <stdint.h>
/* ESPI Slave Registers (Document # 327432-004 Revision 1.0 Chapter 7) */ diff --git a/src/include/fit.h b/src/include/fit.h index a1e970d..1aff4f1 100644 --- a/src/include/fit.h +++ b/src/include/fit.h @@ -4,11 +4,10 @@ #ifndef __LIB_FIT_H__ #define __LIB_FIT_H__
-#include <stddef.h> -#include <stdint.h> #include <device_tree.h> #include <list.h> #include <program_loading.h> +#include <types.h>
struct fit_image_node { const char *name; diff --git a/src/include/program_loading.h b/src/include/program_loading.h index fae70ce..4b3a709 100644 --- a/src/include/program_loading.h +++ b/src/include/program_loading.h @@ -4,8 +4,7 @@
#include <bootmem.h> #include <commonlib/region.h> -#include <stdint.h> -#include <stddef.h> +#include <types.h>
enum { /* Last segment of program. Can be used to take different actions for diff --git a/src/include/spd_cache.h b/src/include/spd_cache.h index 5465aad..a698e5d 100644 --- a/src/include/spd_cache.h +++ b/src/include/spd_cache.h @@ -4,8 +4,7 @@ #define __SPD_CACHE_H
#include <spd_bin.h> -#include <stddef.h> -#include <stdint.h> +#include <types.h>
#define SPD_CACHE_FMAP_NAME "RW_SPD_CACHE" #define SC_SPD_NUMS (CONFIG_DIMM_MAX)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43955 )
Change subject: src/include: Add missing <stdbool.h> ......................................................................
Patch Set 1:
(6 comments)
I've added comments to make the review easier. Thx
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/acpi/acpi_pld.h File src/include/acpi/acpi_pld.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/acpi/acpi_pld.h... PS1, Line 79: bool stdbool
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/device/hypertra... File src/include/device/hypertransport_def.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/device/hypertra... PS1, Line 24: bool stdbool
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/espi.h File src/include/espi.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/espi.h@238 PS1, Line 238: bool stdbool
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/fit.h File src/include/fit.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/fit.h@70 PS1, Line 70: bool stdbool
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/program_loading... File src/include/program_loading.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/program_loading... PS1, Line 197: bool stdbool
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/spd_cache.h File src/include/spd_cache.h:
https://review.coreboot.org/c/coreboot/+/43955/1/src/include/spd_cache.h@19 PS1, Line 19: bool stdbool
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43955 )
Change subject: src/include: Add missing <stdbool.h> ......................................................................
Abandoned