Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31497 )
Change subject: build: Mark bootblock files on x86 as IBB
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/31497/9/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/31497/9/Makefile.inc@1028
PS9, Line 1028: --ibb \
If you really want to add this (I talked to Philipp before about how I don't think this really does anything useful, but knock yourselves out), please make sure it stays entirely optional for boards that don't use it. CBFS attributes are not free. I think the best way to do that may be to create a make variable (e.g. $IBB_TAG) that is only set to "--ibb" when this feature is enabled (maybe controlled via Kconfig), and is otherwise empty. Then use that variable instead of adding the tag directly in all these places.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31497
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83313f035e7fb7e1eb484b323862522e28cb73d4
Gerrit-Change-Number: 31497
Gerrit-PatchSet: 9
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kai Michaelis
kai.michaelis@9elements.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jul 2019 20:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment