Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77417?usp=email )
Change subject: vc/siemens: Only add the include path for hwlib when needed ......................................................................
vc/siemens: Only add the include path for hwlib when needed
This patch moves the line adding hwlib to the include path to the inner makefile so that it doesn't get added to every build, but only when CONFIG_USE_SIEMENS_HWILIB=y
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: Id668b76366a554efff560cec746e637487ebdbf4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/77417 Reviewed-by: Felix Singer service+coreboot-gerrit@felixsinger.de Reviewed-by: Elyes Haouas ehaouas@noos.fr Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Jan Samek jan.samek@siemens.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/siemens/Makefile.inc M src/vendorcode/siemens/hwilib/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: Jan Samek: Looks good to me, approved build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Felix Singer: Looks good to me, approved Frans Hendriks: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/vendorcode/siemens/Makefile.inc b/src/vendorcode/siemens/Makefile.inc index 342375b..88fd1c3 100644 --- a/src/vendorcode/siemens/Makefile.inc +++ b/src/vendorcode/siemens/Makefile.inc @@ -1,5 +1,3 @@ ## SPDX-License-Identifier: GPL-2.0-only
subdirs-$(CONFIG_USE_SIEMENS_HWILIB) += hwilib - -CPPFLAGS_common += -I$(src)/vendorcode/siemens/hwilib diff --git a/src/vendorcode/siemens/hwilib/Makefile.inc b/src/vendorcode/siemens/hwilib/Makefile.inc index 9a5d4be..7b99c0c 100644 --- a/src/vendorcode/siemens/hwilib/Makefile.inc +++ b/src/vendorcode/siemens/hwilib/Makefile.inc @@ -2,3 +2,5 @@
romstage-y += hwilib.c ramstage-y += hwilib.c + +CPPFLAGS_common += -I$(src)/vendorcode/siemens/hwilib