Change in coreboot[master]: src: Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: Add missing 'include <commonlib/helpers.h>'
......................................................................

src: Add missing 'include <commonlib/helpers.h>'

Macro "check_member(structure, member, offset)" needs '<commonlib/helpers.h>'.

Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/uart/pl011.h
M src/soc/cavium/cn81xx/include/soc/soc.h
M src/soc/cavium/cn81xx/spi.c
M src/soc/cavium/cn81xx/timer.c
M src/soc/cavium/cn81xx/uart.c
M src/soc/mediatek/common/include/soc/ddp_common.h
M src/soc/mediatek/common/include/soc/dsi_common.h
M src/soc/mediatek/common/include/soc/gpio_common.h
M src/soc/mediatek/common/include/soc/i2c_common.h
M src/soc/mediatek/common/include/soc/timer.h
M src/soc/mediatek/common/include/soc/usb_common.h
M src/soc/mediatek/mt8173/include/soc/ddp.h
M src/soc/mediatek/mt8173/include/soc/dramc_register.h
M src/soc/mediatek/mt8173/include/soc/dsi.h
M src/soc/mediatek/mt8173/include/soc/flash_controller.h
M src/soc/mediatek/mt8173/include/soc/gpio.h
M src/soc/mediatek/mt8173/include/soc/i2c.h
M src/soc/mediatek/mt8173/include/soc/infracfg.h
M src/soc/mediatek/mt8173/include/soc/mcucfg.h
M src/soc/mediatek/mt8173/include/soc/mipi.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8173/include/soc/spi.h
M src/soc/mediatek/mt8173/include/soc/spm.h
M src/soc/mediatek/mt8173/include/soc/usb.h
M src/soc/mediatek/mt8183/include/soc/ddp.h
M src/soc/mediatek/mt8183/include/soc/dramc_register.h
M src/soc/mediatek/mt8183/include/soc/dsi.h
M src/soc/mediatek/mt8183/include/soc/efuse.h
M src/soc/mediatek/mt8183/include/soc/gpio.h
M src/soc/mediatek/mt8183/include/soc/i2c.h
M src/soc/mediatek/mt8183/include/soc/infracfg.h
M src/soc/mediatek/mt8183/include/soc/mcucfg.h
M src/soc/mediatek/mt8183/include/soc/pll.h
M src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8183/include/soc/smi.h
M src/soc/mediatek/mt8183/include/soc/spi.h
M src/soc/mediatek/mt8183/include/soc/spm.h
M src/soc/mediatek/mt8183/include/soc/usb.h
M src/soc/nvidia/tegra/dc.h
M src/soc/nvidia/tegra/i2c.h
M src/soc/nvidia/tegra/usb.c
M src/soc/nvidia/tegra124/include/soc/clk_rst.h
M src/soc/nvidia/tegra124/include/soc/dma.h
M src/soc/nvidia/tegra124/include/soc/emc.h
M src/soc/nvidia/tegra124/include/soc/flow.h
M src/soc/nvidia/tegra124/include/soc/mc.h
M src/soc/nvidia/tegra124/include/soc/pmc.h
M src/soc/nvidia/tegra124/include/soc/sdram_param.h
M src/soc/nvidia/tegra124/include/soc/spi.h
M src/soc/nvidia/tegra124/include/soc/sysctr.h
M src/soc/nvidia/tegra210/include/soc/clk_rst.h
M src/soc/nvidia/tegra210/include/soc/clst_clk.h
M src/soc/nvidia/tegra210/include/soc/dma.h
M src/soc/nvidia/tegra210/include/soc/emc.h
M src/soc/nvidia/tegra210/include/soc/flow.h
M src/soc/nvidia/tegra210/include/soc/mc.h
M src/soc/nvidia/tegra210/include/soc/pmc.h
M src/soc/nvidia/tegra210/include/soc/sdram_param.h
M src/soc/nvidia/tegra210/include/soc/spi.h
M src/soc/nvidia/tegra210/include/soc/sysctr.h
M src/soc/qualcomm/ipq806x/usb.c
M src/soc/qualcomm/qcs405/usb.c
M src/soc/qualcomm/sdm845/include/soc/clock.h
M src/soc/qualcomm/sdm845/include/soc/efuse.h
M src/soc/qualcomm/sdm845/include/soc/qspi.h
M src/soc/qualcomm/sdm845/usb.c
M src/soc/rockchip/common/include/soc/edp.h
M src/soc/rockchip/common/include/soc/gpio.h
M src/soc/rockchip/common/include/soc/spi.h
M src/soc/rockchip/common/include/soc/vop.h
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/clock.c
M src/soc/rockchip/rk3288/crypto.c
M src/soc/rockchip/rk3288/include/soc/grf.h
M src/soc/rockchip/rk3288/include/soc/hdmi.h
M src/soc/rockchip/rk3288/include/soc/pmu.h
M src/soc/rockchip/rk3288/include/soc/sdram.h
M src/soc/rockchip/rk3288/sdram.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/include/soc/clock.h
M src/soc/rockchip/rk3399/include/soc/grf.h
M src/soc/rockchip/rk3399/include/soc/mipi.h
M src/soc/rockchip/rk3399/include/soc/usb.h
M src/soc/rockchip/rk3399/saradc.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/include/soc/clk.h
M src/soc/samsung/exynos5250/include/soc/dmc.h
M src/soc/samsung/exynos5250/include/soc/dp.h
M src/soc/samsung/exynos5250/include/soc/dsim.h
M src/soc/samsung/exynos5250/include/soc/fimd.h
M src/soc/samsung/exynos5250/include/soc/power.h
M src/soc/samsung/exynos5250/include/soc/spi.h
M src/soc/samsung/exynos5250/include/soc/sysreg.h
M src/soc/samsung/exynos5250/include/soc/tmu.h
M src/soc/samsung/exynos5250/include/soc/trustzone.h
M src/soc/samsung/exynos5250/include/soc/uart.h
M src/soc/samsung/exynos5250/include/soc/usb.h
M src/soc/samsung/exynos5420/i2c.c
M src/soc/samsung/exynos5420/include/soc/clk.h
M src/soc/samsung/exynos5420/include/soc/dmc.h
M src/soc/samsung/exynos5420/include/soc/dp.h
M src/soc/samsung/exynos5420/include/soc/dsim.h
M src/soc/samsung/exynos5420/include/soc/fimd.h
M src/soc/samsung/exynos5420/include/soc/power.h
M src/soc/samsung/exynos5420/include/soc/spi.h
M src/soc/samsung/exynos5420/include/soc/sysreg.h
M src/soc/samsung/exynos5420/include/soc/tmu.h
M src/soc/samsung/exynos5420/include/soc/trustzone.h
M src/soc/samsung/exynos5420/include/soc/uart.h
M src/soc/samsung/exynos5420/include/soc/usb.h
111 files changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37415/1

diff --git a/src/drivers/uart/pl011.h b/src/drivers/uart/pl011.h
index 2568dbc..baf6c31 100644
--- a/src/drivers/uart/pl011.h
+++ b/src/drivers/uart/pl011.h
@@ -10,6 +10,7 @@
 #ifndef __DRIVERS_UART_PL011_H
 #define __DRIVERS_UART_PL011_H

+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <types.h>

diff --git a/src/soc/cavium/cn81xx/include/soc/soc.h b/src/soc/cavium/cn81xx/include/soc/soc.h
index 582cff3..256f722 100644
--- a/src/soc/cavium/cn81xx/include/soc/soc.h
+++ b/src/soc/cavium/cn81xx/include/soc/soc.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H
 #define __SOC_CAVIUM_CN81XX_INCLUDE_SOC_SOC_H

+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <types.h>

diff --git a/src/soc/cavium/cn81xx/spi.c b/src/soc/cavium/cn81xx/spi.c
index 6a5abb1..960f1be 100644
--- a/src/soc/cavium/cn81xx/spi.c
+++ b/src/soc/cavium/cn81xx/spi.c
@@ -18,6 +18,7 @@

#include <device/mmio.h>
 #include <assert.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <endian.h>
 #include <soc/addressmap.h>
diff --git a/src/soc/cavium/cn81xx/timer.c b/src/soc/cavium/cn81xx/timer.c
index bd67d8a..2f24c63 100644
--- a/src/soc/cavium/cn81xx/timer.c
+++ b/src/soc/cavium/cn81xx/timer.c
@@ -19,6 +19,7 @@
 #include <delay.h>
 #include <device/mmio.h>
 #include <arch/lib_helpers.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <soc/clock.h>
 #include <soc/timer.h>
diff --git a/src/soc/cavium/cn81xx/uart.c b/src/soc/cavium/cn81xx/uart.c
index 8a21f00..5e286d2 100644
--- a/src/soc/cavium/cn81xx/uart.c
+++ b/src/soc/cavium/cn81xx/uart.c
@@ -17,6 +17,7 @@
  */

#include <device/mmio.h>
+#include <commonlib/helpers.h>
 #include <console/uart.h>
 #include <delay.h>
 #include <endian.h>
diff --git a/src/soc/mediatek/common/include/soc/ddp_common.h b/src/soc/mediatek/common/include/soc/ddp_common.h
index 6d00ea3..0bc85f6 100644
--- a/src/soc/mediatek/common/include/soc/ddp_common.h
+++ b/src/soc/mediatek/common/include/soc/ddp_common.h
@@ -17,6 +17,7 @@
 #define _DDP_COMMON_H_

#include <soc/addressmap.h>
+#include <commonlib/helpers.h>
 #include <types.h>

diff --git a/src/soc/mediatek/common/include/soc/dsi_common.h b/src/soc/mediatek/common/include/soc/dsi_common.h
index 3052689..8462912 100644
--- a/src/soc/mediatek/common/include/soc/dsi_common.h
+++ b/src/soc/mediatek/common/include/soc/dsi_common.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_DSI_COMMON_H
 #define SOC_MEDIATEK_DSI_COMMON_H

+#include <commonlib/helpers.h>
 #include <edid.h>
 #include <types.h>
 #include <soc/addressmap.h>
diff --git a/src/soc/mediatek/common/include/soc/gpio_common.h b/src/soc/mediatek/common/include/soc/gpio_common.h
index 374c810..4a58fe7 100644
--- a/src/soc/mediatek/common/include/soc/gpio_common.h
+++ b/src/soc/mediatek/common/include/soc/gpio_common.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_COMMON_GPIO_H
 #define SOC_MEDIATEK_COMMON_GPIO_H

+#include <commonlib/helpers.h>
 #include <soc/gpio_base.h>
 #include <stddef.h>
 #include <stdint.h>
diff --git a/src/soc/mediatek/common/include/soc/i2c_common.h b/src/soc/mediatek/common/include/soc/i2c_common.h
index c9dade4..0d9c81b 100644
--- a/src/soc/mediatek/common/include/soc/i2c_common.h
+++ b/src/soc/mediatek/common/include/soc/i2c_common.h
@@ -16,6 +16,8 @@
 #ifndef MTK_COMMON_I2C_H
 #define MTK_COMMON_I2C_H

+#include <commonlib/helpers.h>
+
 /* I2C DMA Registers */
 struct mt_i2c_dma_regs {
    uint32_t dma_int_flag;
diff --git a/src/soc/mediatek/common/include/soc/timer.h b/src/soc/mediatek/common/include/soc/timer.h
index b58d4d3..4d2fee8 100644
--- a/src/soc/mediatek/common/include/soc/timer.h
+++ b/src/soc/mediatek/common/include/soc/timer.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_COMMON_TIMER_H
 #define SOC_MEDIATEK_COMMON_TIMER_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/common/include/soc/usb_common.h b/src/soc/mediatek/common/include/soc/usb_common.h
index 22704e7..ba5ee76 100644
--- a/src/soc/mediatek/common/include/soc/usb_common.h
+++ b/src/soc/mediatek/common/include/soc/usb_common.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_USB_COMMON_H
 #define SOC_MEDIATEK_USB_COMMON_H

+#include <commonlib/helpers.h>
 #include <stddef.h>

/* ip_pw_ctrl0 */
diff --git a/src/soc/mediatek/mt8173/include/soc/ddp.h b/src/soc/mediatek/mt8173/include/soc/ddp.h
index dbac5f7..adea710 100644
--- a/src/soc/mediatek/mt8173/include/soc/ddp.h
+++ b/src/soc/mediatek/mt8173/include/soc/ddp.h
@@ -16,6 +16,7 @@
 #ifndef _MT8173_SOC_DDP_H_
 #define _MT8173_SOC_DDP_H_

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/ddp_common.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8173/include/soc/dramc_register.h b/src/soc/mediatek/mt8173/include/soc/dramc_register.h
index ce65173..5e7d962 100644
--- a/src/soc/mediatek/mt8173/include/soc/dramc_register.h
+++ b/src/soc/mediatek/mt8173/include/soc/dramc_register.h
@@ -16,6 +16,7 @@
 #ifndef _DRAMC_REGISTER_H_
 #define _DRAMC_REGISTER_H_

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8173/include/soc/dsi.h b/src/soc/mediatek/mt8173/include/soc/dsi.h
index e7c1d28..cb85397 100644
--- a/src/soc/mediatek/mt8173/include/soc/dsi.h
+++ b/src/soc/mediatek/mt8173/include/soc/dsi.h
@@ -16,6 +16,7 @@
 #ifndef _DSI_REG_H_
 #define _DSI_REG_H_

+#include <commonlib/helpers.h>
 #include <soc/dsi_common.h>

/* DSI features */
diff --git a/src/soc/mediatek/mt8173/include/soc/flash_controller.h b/src/soc/mediatek/mt8173/include/soc/flash_controller.h
index 8d7db8b..2b9e24b 100644
--- a/src/soc/mediatek/mt8173/include/soc/flash_controller.h
+++ b/src/soc/mediatek/mt8173/include/soc/flash_controller.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8173_FLASH_CONTROLLER_H__
 #define __SOC_MEDIATEK_MT8173_FLASH_CONTROLLER_H__

+#include <commonlib/helpers.h>
 #include <spi-generic.h>
 #include <stdint.h>
 #include <soc/addressmap.h>
diff --git a/src/soc/mediatek/mt8173/include/soc/gpio.h b/src/soc/mediatek/mt8173/include/soc/gpio.h
index 8a6e13a..d452194 100644
--- a/src/soc/mediatek/mt8173/include/soc/gpio.h
+++ b/src/soc/mediatek/mt8173/include/soc/gpio.h
@@ -15,6 +15,7 @@
 #ifndef SOC_MEDIATEK_MT8173_GPIO_H
 #define SOC_MEDIATEK_MT8173_GPIO_H

+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <soc/addressmap.h>
 #include <soc/gpio_common.h>
diff --git a/src/soc/mediatek/mt8173/include/soc/i2c.h b/src/soc/mediatek/mt8173/include/soc/i2c.h
index 6198934..6942440 100644
--- a/src/soc/mediatek/mt8173/include/soc/i2c.h
+++ b/src/soc/mediatek/mt8173/include/soc/i2c.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8173_I2C_H
 #define SOC_MEDIATEK_MT8173_I2C_H

+#include <commonlib/helpers.h>
 #include <soc/i2c_common.h>

/* I2C Register */
diff --git a/src/soc/mediatek/mt8173/include/soc/infracfg.h b/src/soc/mediatek/mt8173/include/soc/infracfg.h
index 60a5209..53e0b9e 100644
--- a/src/soc/mediatek/mt8173/include/soc/infracfg.h
+++ b/src/soc/mediatek/mt8173/include/soc/infracfg.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8173_INFRACFG_H__
 #define __SOC_MEDIATEK_MT8173_INFRACFG_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8173/include/soc/mcucfg.h b/src/soc/mediatek/mt8173/include/soc/mcucfg.h
index 5c01150..273f8d0 100644
--- a/src/soc/mediatek/mt8173/include/soc/mcucfg.h
+++ b/src/soc/mediatek/mt8173/include/soc/mcucfg.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8173_MCUCFG_H__
 #define __SOC_MEDIATEK_MT8173_MCUCFG_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>

struct mt8173_mcucfg_regs {
diff --git a/src/soc/mediatek/mt8173/include/soc/mipi.h b/src/soc/mediatek/mt8173/include/soc/mipi.h
index aec0b25..00e7749 100644
--- a/src/soc/mediatek/mt8173/include/soc/mipi.h
+++ b/src/soc/mediatek/mt8173/include/soc/mipi.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8173_MIPI_H__
 #define __SOC_MEDIATEK_MT8173_MIPI_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8173/include/soc/pll.h b/src/soc/mediatek/mt8173/include/soc/pll.h
index 480ffbf..175a7b9 100644
--- a/src/soc/mediatek/mt8173/include/soc/pll.h
+++ b/src/soc/mediatek/mt8173/include/soc/pll.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8173_PLL_H
 #define SOC_MEDIATEK_MT8173_PLL_H

+#include <commonlib/helpers.h>
 #include <soc/emi.h>
 #include <soc/pll_common.h>

diff --git a/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h b/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
index 3687a29..45d6148 100644
--- a/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
+++ b/src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8173_PMIC_WRAP_H
 #define SOC_MEDIATEK_MT8173_PMIC_WRAP_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/pmic_wrap_common.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8173/include/soc/spi.h b/src/soc/mediatek/mt8173/include/soc/spi.h
index 58bf517..169352d 100644
--- a/src/soc/mediatek/mt8173/include/soc/spi.h
+++ b/src/soc/mediatek/mt8173/include/soc/spi.h
@@ -16,6 +16,7 @@
 #ifndef MTK_MT8173_SPI_H
 #define MTK_MT8173_SPI_H

+#include <commonlib/helpers.h>
 #include <soc/spi_common.h>

#define SPI_BUS_NUMBER 1
diff --git a/src/soc/mediatek/mt8173/include/soc/spm.h b/src/soc/mediatek/mt8173/include/soc/spm.h
index 133c8a3..638a701 100644
--- a/src/soc/mediatek/mt8173/include/soc/spm.h
+++ b/src/soc/mediatek/mt8173/include/soc/spm.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8173_SPM_H__
 #define __SOC_MEDIATEK_MT8173_SPM_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <stddef.h>

diff --git a/src/soc/mediatek/mt8173/include/soc/usb.h b/src/soc/mediatek/mt8173/include/soc/usb.h
index 8e74436..f170695 100644
--- a/src/soc/mediatek/mt8173/include/soc/usb.h
+++ b/src/soc/mediatek/mt8173/include/soc/usb.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8173_USB_H
 #define SOC_MEDIATEK_MT8173_USB_H

+#include <commonlib/helpers.h>
 #include <soc/usb_common.h>

struct ssusb_sif_port {
diff --git a/src/soc/mediatek/mt8183/include/soc/ddp.h b/src/soc/mediatek/mt8183/include/soc/ddp.h
index 479417c..8217217 100644
--- a/src/soc/mediatek/mt8183/include/soc/ddp.h
+++ b/src/soc/mediatek/mt8183/include/soc/ddp.h
@@ -16,6 +16,7 @@
 #ifndef _MT8183_SOC_DDP_H_
 #define _MT8183_SOC_DDP_H_

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/ddp_common.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/dramc_register.h b/src/soc/mediatek/mt8183/include/soc/dramc_register.h
index b3ee6af..eb79201 100644
--- a/src/soc/mediatek/mt8183/include/soc/dramc_register.h
+++ b/src/soc/mediatek/mt8183/include/soc/dramc_register.h
@@ -16,6 +16,7 @@
 #ifndef _DRAMC_REGISTER_H_
 #define _DRAMC_REGISTER_H_

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <types.h>
 #include <soc/addressmap.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/dsi.h b/src/soc/mediatek/mt8183/include/soc/dsi.h
index 8813f94..e3592e3 100644
--- a/src/soc/mediatek/mt8183/include/soc/dsi.h
+++ b/src/soc/mediatek/mt8183/include/soc/dsi.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_DSI_H
 #define SOC_MEDIATEK_MT8183_DSI_H

+#include <commonlib/helpers.h>
 #include <soc/dsi_common.h>

/* DSI features */
diff --git a/src/soc/mediatek/mt8183/include/soc/efuse.h b/src/soc/mediatek/mt8183/include/soc/efuse.h
index 32126ab..7ea0a02 100644
--- a/src/soc/mediatek/mt8183/include/soc/efuse.h
+++ b/src/soc/mediatek/mt8183/include/soc/efuse.h
@@ -16,6 +16,7 @@
 #ifndef _MTK_EFUSE_H
 #define _MTK_EFUSE_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8183/include/soc/gpio.h b/src/soc/mediatek/mt8183/include/soc/gpio.h
index a0d6262..cab7719 100644
--- a/src/soc/mediatek/mt8183/include/soc/gpio.h
+++ b/src/soc/mediatek/mt8183/include/soc/gpio.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_GPIO_H
 #define SOC_MEDIATEK_MT8183_GPIO_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/gpio_common.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/i2c.h b/src/soc/mediatek/mt8183/include/soc/i2c.h
index a75b6f0..0b8a7f6 100644
--- a/src/soc/mediatek/mt8183/include/soc/i2c.h
+++ b/src/soc/mediatek/mt8183/include/soc/i2c.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_I2C_H
 #define SOC_MEDIATEK_MT8183_I2C_H

+#include <commonlib/helpers.h>
 #include <soc/i2c_common.h>

/* I2C Register */
diff --git a/src/soc/mediatek/mt8183/include/soc/infracfg.h b/src/soc/mediatek/mt8183/include/soc/infracfg.h
index 922d977..cacaa4e 100644
--- a/src/soc/mediatek/mt8183/include/soc/infracfg.h
+++ b/src/soc/mediatek/mt8183/include/soc/infracfg.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_INFRACFG_H
 #define SOC_MEDIATEK_MT8183_INFRACFG_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8183/include/soc/mcucfg.h b/src/soc/mediatek/mt8183/include/soc/mcucfg.h
index 0a1232a..2d1f6ca 100644
--- a/src/soc/mediatek/mt8183/include/soc/mcucfg.h
+++ b/src/soc/mediatek/mt8183/include/soc/mcucfg.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_MCUCFG_H
 #define SOC_MEDIATEK_MT8183_MCUCFG_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8183/include/soc/pll.h b/src/soc/mediatek/mt8183/include/soc/pll.h
index 5a24e75..01d9a48 100644
--- a/src/soc/mediatek/mt8183/include/soc/pll.h
+++ b/src/soc/mediatek/mt8183/include/soc/pll.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_PLL_H
 #define SOC_MEDIATEK_MT8183_PLL_H

+#include <commonlib/helpers.h>
 #include <types.h>
 #include <soc/pll_common.h>

diff --git a/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h b/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
index da94230..70ef502 100644
--- a/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
+++ b/src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_MEDIATEK_MT8183_PMIC_WRAP_H__
 #define __SOC_MEDIATEK_MT8183_PMIC_WRAP_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/pmic_wrap_common.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/smi.h b/src/soc/mediatek/mt8183/include/soc/smi.h
index e9051c2..6f9d6a9 100644
--- a/src/soc/mediatek/mt8183/include/soc/smi.h
+++ b/src/soc/mediatek/mt8183/include/soc/smi.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_SMI_H
 #define SOC_MEDIATEK_MT8183_SMI_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/mediatek/mt8183/include/soc/spi.h b/src/soc/mediatek/mt8183/include/soc/spi.h
index f718081..6ad5ecf 100644
--- a/src/soc/mediatek/mt8183/include/soc/spi.h
+++ b/src/soc/mediatek/mt8183/include/soc/spi.h
@@ -16,6 +16,7 @@
 #ifndef MTK_MT8183_SPI_H
 #define MTK_MT8183_SPI_H

+#include <commonlib/helpers.h>
 #include <soc/spi_common.h>

#define SPI_BUS_NUMBER 6
diff --git a/src/soc/mediatek/mt8183/include/soc/spm.h b/src/soc/mediatek/mt8183/include/soc/spm.h
index d0a7aa7..86b4a59 100644
--- a/src/soc/mediatek/mt8183/include/soc/spm.h
+++ b/src/soc/mediatek/mt8183/include/soc/spm.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_SPM_H
 #define SOC_MEDIATEK_MT8183_SPM_H

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <stdint.h>
 #include <types.h>
diff --git a/src/soc/mediatek/mt8183/include/soc/usb.h b/src/soc/mediatek/mt8183/include/soc/usb.h
index 57d4e78..233a55d 100644
--- a/src/soc/mediatek/mt8183/include/soc/usb.h
+++ b/src/soc/mediatek/mt8183/include/soc/usb.h
@@ -16,6 +16,7 @@
 #ifndef SOC_MEDIATEK_MT8183_USB_H
 #define SOC_MEDIATEK_MT8183_USB_H

+#include <commonlib/helpers.h>
 #include <soc/usb_common.h>

struct ssusb_sif_port {
diff --git a/src/soc/nvidia/tegra/dc.h b/src/soc/nvidia/tegra/dc.h
index 56332e4..4a36616 100644
--- a/src/soc/nvidia/tegra/dc.h
+++ b/src/soc/nvidia/tegra/dc.h
@@ -16,6 +16,8 @@

#ifndef __SOC_NVIDIA_TEGRA_DC_H
 #define __SOC_NVIDIA_TEGRA_DC_H
+
+#include <commonlib/helpers.h>
 #include <device/device.h>
 #include <stddef.h>
 #include <types.h>
diff --git a/src/soc/nvidia/tegra/i2c.h b/src/soc/nvidia/tegra/i2c.h
index a2bf950..e1e2ae2 100644
--- a/src/soc/nvidia/tegra/i2c.h
+++ b/src/soc/nvidia/tegra/i2c.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_NVIDIA_TEGRA_I2C_H__
 #define __SOC_NVIDIA_TEGRA_I2C_H__

+#include <commonlib/helpers.h>
 #include <stdint.h>

void i2c_init(unsigned int bus);
diff --git a/src/soc/nvidia/tegra/usb.c b/src/soc/nvidia/tegra/usb.c
index 55d80ed..fe59b3d 100644
--- a/src/soc/nvidia/tegra/usb.c
+++ b/src/soc/nvidia/tegra/usb.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <delay.h>
 #include <device/mmio.h>
 #include <console/console.h>
diff --git a/src/soc/nvidia/tegra124/include/soc/clk_rst.h b/src/soc/nvidia/tegra124/include/soc/clk_rst.h
index 07e710a..4c34cc7 100644
--- a/src/soc/nvidia/tegra124/include/soc/clk_rst.h
+++ b/src/soc/nvidia/tegra124/include/soc/clk_rst.h
@@ -16,6 +16,8 @@
 #ifndef _TEGRA124_CLK_RST_H_
 #define _TEGRA124_CLK_RST_H_

+#include <commonlib/helpers.h>
+
 /* Clock/Reset Controller (CLK_RST_CONTROLLER_) regs */
 struct  __packed clk_rst_ctlr {
    u32 rst_src;			/* _RST_SOURCE,             0x000 */
diff --git a/src/soc/nvidia/tegra124/include/soc/dma.h b/src/soc/nvidia/tegra124/include/soc/dma.h
index 3d6d209..d06a659 100644
--- a/src/soc/nvidia/tegra124/include/soc/dma.h
+++ b/src/soc/nvidia/tegra124/include/soc/dma.h
@@ -18,6 +18,7 @@
 #ifndef __NVIDIA_TEGRA124_DMA_H__
 #define __NVIDIA_TEGRA124_DMA_H__

+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <soc/addressmap.h>

diff --git a/src/soc/nvidia/tegra124/include/soc/emc.h b/src/soc/nvidia/tegra124/include/soc/emc.h
index 8e190f9..661432d 100644
--- a/src/soc/nvidia/tegra124/include/soc/emc.h
+++ b/src/soc/nvidia/tegra124/include/soc/emc.h
@@ -17,6 +17,7 @@
 #ifndef __SOC_NVIDIA_TEGRA124_EMC_H__
 #define __SOC_NVIDIA_TEGRA124_EMC_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra124/include/soc/flow.h b/src/soc/nvidia/tegra124/include/soc/flow.h
index 84bf705..f2ee702 100644
--- a/src/soc/nvidia/tegra124/include/soc/flow.h
+++ b/src/soc/nvidia/tegra124/include/soc/flow.h
@@ -16,6 +16,8 @@
 #ifndef _TEGRA124_FLOW_H_
 #define _TEGRA124_FLOW_H_

+#include <commonlib/helpers.h>
+
 struct flow_ctlr {
    u32 halt_cpu_events;	/* offset 0x00 */
    u32 halt_cop_events;	/* offset 0x04 */
diff --git a/src/soc/nvidia/tegra124/include/soc/mc.h b/src/soc/nvidia/tegra124/include/soc/mc.h
index f249ecc..042a068 100644
--- a/src/soc/nvidia/tegra124/include/soc/mc.h
+++ b/src/soc/nvidia/tegra124/include/soc/mc.h
@@ -17,6 +17,7 @@
 #ifndef __SOC_NVIDIA_TEGRA124_MC_H__
 #define __SOC_NVIDIA_TEGRA124_MC_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra124/include/soc/pmc.h b/src/soc/nvidia/tegra124/include/soc/pmc.h
index b6f60e8..60301a2 100644
--- a/src/soc/nvidia/tegra124/include/soc/pmc.h
+++ b/src/soc/nvidia/tegra124/include/soc/pmc.h
@@ -16,6 +16,7 @@
 #ifndef _TEGRA124_PMC_H_
 #define _TEGRA124_PMC_H_

+#include <commonlib/helpers.h>
 #include <stdint.h>

enum {
diff --git a/src/soc/nvidia/tegra124/include/soc/sdram_param.h b/src/soc/nvidia/tegra124/include/soc/sdram_param.h
index 938d655c..91d853b 100644
--- a/src/soc/nvidia/tegra124/include/soc/sdram_param.h
+++ b/src/soc/nvidia/tegra124/include/soc/sdram_param.h
@@ -24,6 +24,7 @@
 #ifndef __SOC_NVIDIA_TEGRA124_SDRAM_PARAM_H__
 #define __SOC_NVIDIA_TEGRA124_SDRAM_PARAM_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra124/include/soc/spi.h b/src/soc/nvidia/tegra124/include/soc/spi.h
index 875e880..7c6c750 100644
--- a/src/soc/nvidia/tegra124/include/soc/spi.h
+++ b/src/soc/nvidia/tegra124/include/soc/spi.h
@@ -16,6 +16,7 @@
 #ifndef __NVIDIA_TEGRA124_SPI_H__
 #define __NVIDIA_TEGRA124_SPI_H__

+#include <commonlib/helpers.h>
 #include <spi-generic.h>
 #include <soc/dma.h>
 #include <stddef.h>
diff --git a/src/soc/nvidia/tegra124/include/soc/sysctr.h b/src/soc/nvidia/tegra124/include/soc/sysctr.h
index 5b5e4c6..5a4239c 100644
--- a/src/soc/nvidia/tegra124/include/soc/sysctr.h
+++ b/src/soc/nvidia/tegra124/include/soc/sysctr.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_NVIDIA_TEGRA124_SYSCTR_H__
 #define __SOC_NVIDIA_TEGRA124_SYSCTR_H__

+#include <commonlib/helpers.h>
 #include <stdint.h>

enum {
diff --git a/src/soc/nvidia/tegra210/include/soc/clk_rst.h b/src/soc/nvidia/tegra210/include/soc/clk_rst.h
index 42eebed..224c66f 100644
--- a/src/soc/nvidia/tegra210/include/soc/clk_rst.h
+++ b/src/soc/nvidia/tegra210/include/soc/clk_rst.h
@@ -15,6 +15,8 @@

#ifndef _TEGRA210_CLK_RST_H_
 #define _TEGRA210_CLK_RST_H_
+
+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <stddef.h>

diff --git a/src/soc/nvidia/tegra210/include/soc/clst_clk.h b/src/soc/nvidia/tegra210/include/soc/clst_clk.h
index 661fd1d..6dc0936 100644
--- a/src/soc/nvidia/tegra210/include/soc/clst_clk.h
+++ b/src/soc/nvidia/tegra210/include/soc/clst_clk.h
@@ -16,6 +16,8 @@
 #ifndef _TEGRA210_CLST_CLK_H_
 #define _TEGRA210_CLST_CLK_H_

+#include <commonlib/helpers.h>
+
 /* Cluster Clock (CLUSTER_CLOCKS_PUBLIC_) regs */
 struct  __packed clst_clk_ctlr {
    u32 pllx_base;			/* _PLLX_BASE,              0x000 */
diff --git a/src/soc/nvidia/tegra210/include/soc/dma.h b/src/soc/nvidia/tegra210/include/soc/dma.h
index 6d93419..a1481ae 100644
--- a/src/soc/nvidia/tegra210/include/soc/dma.h
+++ b/src/soc/nvidia/tegra210/include/soc/dma.h
@@ -17,6 +17,7 @@
 #ifndef __NVIDIA_TEGRA210_DMA_H__
 #define __NVIDIA_TEGRA210_DMA_H__

+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <soc/addressmap.h>
 #include <types.h>
diff --git a/src/soc/nvidia/tegra210/include/soc/emc.h b/src/soc/nvidia/tegra210/include/soc/emc.h
index 289aa72..2ff5afd 100644
--- a/src/soc/nvidia/tegra210/include/soc/emc.h
+++ b/src/soc/nvidia/tegra210/include/soc/emc.h
@@ -17,6 +17,7 @@
 #ifndef __SOC_NVIDIA_TEGRA210_EMC_H__
 #define __SOC_NVIDIA_TEGRA210_EMC_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra210/include/soc/flow.h b/src/soc/nvidia/tegra210/include/soc/flow.h
index c30175a..8fda656 100644
--- a/src/soc/nvidia/tegra210/include/soc/flow.h
+++ b/src/soc/nvidia/tegra210/include/soc/flow.h
@@ -16,6 +16,8 @@
 #ifndef _TEGRA210_FLOW_H_
 #define _TEGRA210_FLOW_H_

+#include <commonlib/helpers.h>
+
 struct flow_ctlr {
    u32 halt_cpu_events;	/* offset 0x00 */
    u32 halt_cop_events;	/* offset 0x04 */
diff --git a/src/soc/nvidia/tegra210/include/soc/mc.h b/src/soc/nvidia/tegra210/include/soc/mc.h
index b78305a..6fa0b23 100644
--- a/src/soc/nvidia/tegra210/include/soc/mc.h
+++ b/src/soc/nvidia/tegra210/include/soc/mc.h
@@ -17,6 +17,7 @@
 #ifndef __SOC_NVIDIA_TEGRA210_MC_H__
 #define __SOC_NVIDIA_TEGRA210_MC_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra210/include/soc/pmc.h b/src/soc/nvidia/tegra210/include/soc/pmc.h
index ad0d170..a889d6d 100644
--- a/src/soc/nvidia/tegra210/include/soc/pmc.h
+++ b/src/soc/nvidia/tegra210/include/soc/pmc.h
@@ -16,6 +16,7 @@
 #ifndef _TEGRA210_PMC_H_
 #define _TEGRA210_PMC_H_

+#include <commonlib/helpers.h>
 #include <stdint.h>

enum {
diff --git a/src/soc/nvidia/tegra210/include/soc/sdram_param.h b/src/soc/nvidia/tegra210/include/soc/sdram_param.h
index 0b6f7a0..c86227e 100644
--- a/src/soc/nvidia/tegra210/include/soc/sdram_param.h
+++ b/src/soc/nvidia/tegra210/include/soc/sdram_param.h
@@ -24,6 +24,7 @@
 #ifndef __SOC_NVIDIA_TEGRA210_SDRAM_PARAM_H__
 #define __SOC_NVIDIA_TEGRA210_SDRAM_PARAM_H__

+#include <commonlib/helpers.h>
 #include <stddef.h>
 #include <stdint.h>

diff --git a/src/soc/nvidia/tegra210/include/soc/spi.h b/src/soc/nvidia/tegra210/include/soc/spi.h
index 46c1c3c..2269fc2 100644
--- a/src/soc/nvidia/tegra210/include/soc/spi.h
+++ b/src/soc/nvidia/tegra210/include/soc/spi.h
@@ -17,6 +17,7 @@
 #ifndef __NVIDIA_TEGRA210_SPI_H__
 #define __NVIDIA_TEGRA210_SPI_H__

+#include <commonlib/helpers.h>
 #include <soc/dma.h>
 #include <spi-generic.h>
 #include <stddef.h>
diff --git a/src/soc/nvidia/tegra210/include/soc/sysctr.h b/src/soc/nvidia/tegra210/include/soc/sysctr.h
index f182c66..1c6caef 100644
--- a/src/soc/nvidia/tegra210/include/soc/sysctr.h
+++ b/src/soc/nvidia/tegra210/include/soc/sysctr.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_NVIDIA_TEGRA210_SYSCTR_H__
 #define __SOC_NVIDIA_TEGRA210_SYSCTR_H__

+#include <commonlib/helpers.h>
 #include <stdint.h>

enum {
diff --git a/src/soc/qualcomm/ipq806x/usb.c b/src/soc/qualcomm/ipq806x/usb.c
index 35285cd..412d0a5 100644
--- a/src/soc/qualcomm/ipq806x/usb.c
+++ b/src/soc/qualcomm/ipq806x/usb.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <console/console.h>
 #include <delay.h>
diff --git a/src/soc/qualcomm/qcs405/usb.c b/src/soc/qualcomm/qcs405/usb.c
index 765755c..e01e3b1 100644
--- a/src/soc/qualcomm/qcs405/usb.c
+++ b/src/soc/qualcomm/qcs405/usb.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <console/console.h>
 #include <delay.h>
diff --git a/src/soc/qualcomm/sdm845/include/soc/clock.h b/src/soc/qualcomm/sdm845/include/soc/clock.h
index 1f79d95..08bd7fa 100644
--- a/src/soc/qualcomm/sdm845/include/soc/clock.h
+++ b/src/soc/qualcomm/sdm845/include/soc/clock.h
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/qualcomm/sdm845/include/soc/efuse.h b/src/soc/qualcomm/sdm845/include/soc/efuse.h
index 309193c..52616ac 100644
--- a/src/soc/qualcomm/sdm845/include/soc/efuse.h
+++ b/src/soc/qualcomm/sdm845/include/soc/efuse.h
@@ -16,6 +16,8 @@
 #ifndef __SOC_QUALCOMM_SDM845_EFUSE_ADDRESS_MAP_H__
 #define __SOC_QUALCOMM_SDM845_EFUSE_ADDRESS_MAP_H__

+#include <commonlib/helpers.h>
+
 /**
  *  USB EFUSE registers
  */
diff --git a/src/soc/qualcomm/sdm845/include/soc/qspi.h b/src/soc/qualcomm/sdm845/include/soc/qspi.h
index 3f83421..990be9e 100644
--- a/src/soc/qualcomm/sdm845/include/soc/qspi.h
+++ b/src/soc/qualcomm/sdm845/include/soc/qspi.h
@@ -12,6 +12,8 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  */
+
+#include <commonlib/helpers.h>
 #include <types.h>
 #include <soc/addressmap.h>
 #include <spi-generic.h>
diff --git a/src/soc/qualcomm/sdm845/usb.c b/src/soc/qualcomm/sdm845/usb.c
index bb0509b..60e11ae 100644
--- a/src/soc/qualcomm/sdm845/usb.c
+++ b/src/soc/qualcomm/sdm845/usb.c
@@ -14,6 +14,7 @@
  */

#include <arch/mmio.h>
+#include <commonlib/helpers.h>
 #include <console/console.h>
 #include <delay.h>
 #include <soc/usb.h>
diff --git a/src/soc/rockchip/common/include/soc/edp.h b/src/soc/rockchip/common/include/soc/edp.h
index 58986d1..817d632 100644
--- a/src/soc/rockchip/common/include/soc/edp.h
+++ b/src/soc/rockchip/common/include/soc/edp.h
@@ -16,6 +16,7 @@
 #ifndef __RK_DP_H
 #define __RK_DP_H

+#include <commonlib/helpers.h>
 #include <edid.h>

struct rk_edp_regs {
diff --git a/src/soc/rockchip/common/include/soc/gpio.h b/src/soc/rockchip/common/include/soc/gpio.h
index 6660374..d3991aa 100644
--- a/src/soc/rockchip/common/include/soc/gpio.h
+++ b/src/soc/rockchip/common/include/soc/gpio.h
@@ -16,6 +16,7 @@
 #ifndef __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_GPIO_H
 #define __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_GPIO_H

+#include <commonlib/helpers.h>
 #include <types.h>

#define GPIO(p, b, i) ((gpio_t){.port = p, .bank = GPIO_##b, .idx = i})
diff --git a/src/soc/rockchip/common/include/soc/spi.h b/src/soc/rockchip/common/include/soc/spi.h
index ce5de83..dcb4996 100644
--- a/src/soc/rockchip/common/include/soc/spi.h
+++ b/src/soc/rockchip/common/include/soc/spi.h
@@ -17,6 +17,8 @@
 #define __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_SPI_H

/* This driver serves as a CBFS media source. */
+
+#include <commonlib/helpers.h>
 #include <spi-generic.h>
 #include <stddef.h>

diff --git a/src/soc/rockchip/common/include/soc/vop.h b/src/soc/rockchip/common/include/soc/vop.h
index 69d1184..1ddc5ec 100644
--- a/src/soc/rockchip/common/include/soc/vop.h
+++ b/src/soc/rockchip/common/include/soc/vop.h
@@ -15,6 +15,8 @@

#ifndef _ROCKCHIP_LCD_H_
 #define _ROCKCHIP_LCD_H_
+
+#include <commonlib/helpers.h>
 #include <stdint.h>
 #include <edid.h>

diff --git a/src/soc/rockchip/common/pwm.c b/src/soc/rockchip/common/pwm.c
index 98ef21f..6029295 100644
--- a/src/soc/rockchip/common/pwm.c
+++ b/src/soc/rockchip/common/pwm.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <soc/addressmap.h>
 #include <soc/grf.h>
diff --git a/src/soc/rockchip/rk3288/clock.c b/src/soc/rockchip/rk3288/clock.c
index 1c490b4..84bc188 100644
--- a/src/soc/rockchip/rk3288/clock.c
+++ b/src/soc/rockchip/rk3288/clock.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <assert.h>
 #include <console/console.h>
diff --git a/src/soc/rockchip/rk3288/crypto.c b/src/soc/rockchip/rk3288/crypto.c
index 00885bc..a40630f 100644
--- a/src/soc/rockchip/rk3288/crypto.c
+++ b/src/soc/rockchip/rk3288/crypto.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <assert.h>
 #include <console/console.h>
diff --git a/src/soc/rockchip/rk3288/include/soc/grf.h b/src/soc/rockchip/rk3288/include/soc/grf.h
index 4a546ea..d4a5884 100644
--- a/src/soc/rockchip/rk3288/include/soc/grf.h
+++ b/src/soc/rockchip/rk3288/include/soc/grf.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3288_GRF_H__
 #define __SOC_ROCKCHIP_RK3288_GRF_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/soc.h>
 #include <types.h>
diff --git a/src/soc/rockchip/rk3288/include/soc/hdmi.h b/src/soc/rockchip/rk3288/include/soc/hdmi.h
index 3089949..2a7041e 100644
--- a/src/soc/rockchip/rk3288/include/soc/hdmi.h
+++ b/src/soc/rockchip/rk3288/include/soc/hdmi.h
@@ -18,6 +18,7 @@
 #ifndef __SOC_HDMI_H__
 #define __SOC_HDMI_H__

+#include <commonlib/helpers.h>
 #include <types.h>

#define HDMI_EDID_BLOCK_SIZE            128
diff --git a/src/soc/rockchip/rk3288/include/soc/pmu.h b/src/soc/rockchip/rk3288/include/soc/pmu.h
index 5ef9544..a1cff54 100644
--- a/src/soc/rockchip/rk3288/include/soc/pmu.h
+++ b/src/soc/rockchip/rk3288/include/soc/pmu.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3288_PMU_H__
 #define __SOC_ROCKCHIP_RK3288_PMU_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>

struct rk3288_pmu_regs {
diff --git a/src/soc/rockchip/rk3288/include/soc/sdram.h b/src/soc/rockchip/rk3288/include/soc/sdram.h
index 3ad51b6..85b4e82 100644
--- a/src/soc/rockchip/rk3288/include/soc/sdram.h
+++ b/src/soc/rockchip/rk3288/include/soc/sdram.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3288_SDRAM_H__
 #define __SOC_ROCKCHIP_RK3288_SDRAM_H__

+#include <commonlib/helpers.h>
 #include <types.h>

enum {
diff --git a/src/soc/rockchip/rk3288/sdram.c b/src/soc/rockchip/rk3288/sdram.c
index 74038b0..f6a45dd 100644
--- a/src/soc/rockchip/rk3288/sdram.c
+++ b/src/soc/rockchip/rk3288/sdram.c
@@ -12,6 +12,8 @@
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  */
+
+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <console/console.h>
 #include <delay.h>
diff --git a/src/soc/rockchip/rk3288/tsadc.c b/src/soc/rockchip/rk3288/tsadc.c
index 7e5823c..f47ec26 100644
--- a/src/soc/rockchip/rk3288/tsadc.c
+++ b/src/soc/rockchip/rk3288/tsadc.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <soc/clock.h>
 #include <soc/grf.h>
diff --git a/src/soc/rockchip/rk3399/include/soc/clock.h b/src/soc/rockchip/rk3399/include/soc/clock.h
index e2aeaea..c78765c 100644
--- a/src/soc/rockchip/rk3399/include/soc/clock.h
+++ b/src/soc/rockchip/rk3399/include/soc/clock.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3399_CLOCK_H__
 #define __SOC_ROCKCHIP_RK3399_CLOCK_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <types.h>

diff --git a/src/soc/rockchip/rk3399/include/soc/grf.h b/src/soc/rockchip/rk3399/include/soc/grf.h
index 9bda967..af95c05 100644
--- a/src/soc/rockchip/rk3399/include/soc/grf.h
+++ b/src/soc/rockchip/rk3399/include/soc/grf.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3399_GRF_H__
 #define __SOC_ROCKCHIP_RK3399_GRF_H__

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>
 #include <soc/soc.h>
 #include <types.h>
diff --git a/src/soc/rockchip/rk3399/include/soc/mipi.h b/src/soc/rockchip/rk3399/include/soc/mipi.h
index 469a052..40cf830 100644
--- a/src/soc/rockchip/rk3399/include/soc/mipi.h
+++ b/src/soc/rockchip/rk3399/include/soc/mipi.h
@@ -16,6 +16,7 @@
 #ifndef __RK_MIPI_H
 #define __RK_MIPI_H

+#include <commonlib/helpers.h>
 #include <types.h>

struct rk_mipi_regs {
diff --git a/src/soc/rockchip/rk3399/include/soc/usb.h b/src/soc/rockchip/rk3399/include/soc/usb.h
index c2fa1a2..ddaaff3 100644
--- a/src/soc/rockchip/rk3399/include/soc/usb.h
+++ b/src/soc/rockchip/rk3399/include/soc/usb.h
@@ -16,6 +16,7 @@
 #ifndef __SOC_ROCKCHIP_RK3399_USB_H_
 #define __SOC_ROCKCHIP_RK3399_USB_H_

+#include <commonlib/helpers.h>
 #include <soc/addressmap.h>

/* Global constants */
diff --git a/src/soc/rockchip/rk3399/saradc.c b/src/soc/rockchip/rk3399/saradc.c
index 8dd3cb4..412d85a 100644
--- a/src/soc/rockchip/rk3399/saradc.c
+++ b/src/soc/rockchip/rk3399/saradc.c
@@ -14,6 +14,7 @@
  *
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <assert.h>
 #include <delay.h>
diff --git a/src/soc/rockchip/rk3399/tsadc.c b/src/soc/rockchip/rk3399/tsadc.c
index b81aa93..ce6abc5 100644
--- a/src/soc/rockchip/rk3399/tsadc.c
+++ b/src/soc/rockchip/rk3399/tsadc.c
@@ -13,6 +13,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <delay.h>
 #include <soc/clock.h>
diff --git a/src/soc/samsung/exynos5250/include/soc/clk.h b/src/soc/samsung/exynos5250/include/soc/clk.h
index fab0444..0601112 100644
--- a/src/soc/samsung/exynos5250/include/soc/clk.h
+++ b/src/soc/samsung/exynos5250/include/soc/clk.h
@@ -17,6 +17,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_CLK_H
 #define CPU_SAMSUNG_EXYNOS5250_CLK_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>
 #include <soc/dmc.h>
 #include <soc/pinmux.h>
diff --git a/src/soc/samsung/exynos5250/include/soc/dmc.h b/src/soc/samsung/exynos5250/include/soc/dmc.h
index 993987f..b59f0e2 100644
--- a/src/soc/samsung/exynos5250/include/soc/dmc.h
+++ b/src/soc/samsung/exynos5250/include/soc/dmc.h
@@ -16,6 +16,7 @@

#ifndef __ASSEMBLER__

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

struct exynos5_dmc {
diff --git a/src/soc/samsung/exynos5250/include/soc/dp.h b/src/soc/samsung/exynos5250/include/soc/dp.h
index b5e65fb..f5d3628 100644
--- a/src/soc/samsung/exynos5250/include/soc/dp.h
+++ b/src/soc/samsung/exynos5250/include/soc/dp.h
@@ -19,6 +19,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_DP_H
 #define CPU_SAMSUNG_EXYNOS5250_DP_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* DSIM register map */
diff --git a/src/soc/samsung/exynos5250/include/soc/dsim.h b/src/soc/samsung/exynos5250/include/soc/dsim.h
index 301d0a9..8d7f6de 100644
--- a/src/soc/samsung/exynos5250/include/soc/dsim.h
+++ b/src/soc/samsung/exynos5250/include/soc/dsim.h
@@ -18,6 +18,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_DSIM_H
 #define CPU_SAMSUNG_EXYNOS5250_DSIM_H

+#include <commonlib/helpers.h>
+
 /* DSIM register map */
 struct exynos5_dsim {
    unsigned int status;
diff --git a/src/soc/samsung/exynos5250/include/soc/fimd.h b/src/soc/samsung/exynos5250/include/soc/fimd.h
index e58891e..ee8a84a 100644
--- a/src/soc/samsung/exynos5250/include/soc/fimd.h
+++ b/src/soc/samsung/exynos5250/include/soc/fimd.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_FIMD_H
 #define CPU_SAMSUNG_EXYNOS5250_FIMD_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* FIMD register map */
diff --git a/src/soc/samsung/exynos5250/include/soc/power.h b/src/soc/samsung/exynos5250/include/soc/power.h
index 297ee19..7cb393f 100644
--- a/src/soc/samsung/exynos5250/include/soc/power.h
+++ b/src/soc/samsung/exynos5250/include/soc/power.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_POWER_H
 #define CPU_SAMSUNG_EXYNOS5250_POWER_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* Enable HW thermal trip with PS_HOLD_CONTROL register ENABLE_HW_TRIP bit */
diff --git a/src/soc/samsung/exynos5250/include/soc/spi.h b/src/soc/samsung/exynos5250/include/soc/spi.h
index 19ee7f8..9aa07ec 100644
--- a/src/soc/samsung/exynos5250/include/soc/spi.h
+++ b/src/soc/samsung/exynos5250/include/soc/spi.h
@@ -16,6 +16,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_SPI_H
 #define CPU_SAMSUNG_EXYNOS5250_SPI_H

+#include <commonlib/helpers.h>
 #include <boot_device.h>

/* SPI peripheral register map; padded to 64KB */
diff --git a/src/soc/samsung/exynos5250/include/soc/sysreg.h b/src/soc/samsung/exynos5250/include/soc/sysreg.h
index 397cdb3..8e6032d 100644
--- a/src/soc/samsung/exynos5250/include/soc/sysreg.h
+++ b/src/soc/samsung/exynos5250/include/soc/sysreg.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_SYSREG_H
 #define CPU_SAMSUNG_EXYNOS5250_SYSREG_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* sysreg map */
diff --git a/src/soc/samsung/exynos5250/include/soc/tmu.h b/src/soc/samsung/exynos5250/include/soc/tmu.h
index cb92c16..f3c90af 100644
--- a/src/soc/samsung/exynos5250/include/soc/tmu.h
+++ b/src/soc/samsung/exynos5250/include/soc/tmu.h
@@ -18,6 +18,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_TMU_H
 #define CPU_SAMSUNG_EXYNOS5250_TMU_H

+#include <commonlib/helpers.h>
+
 struct tmu_reg {
    unsigned int triminfo;
    unsigned int rsvd1;
diff --git a/src/soc/samsung/exynos5250/include/soc/trustzone.h b/src/soc/samsung/exynos5250/include/soc/trustzone.h
index 9a4afbf..d2155ea 100644
--- a/src/soc/samsung/exynos5250/include/soc/trustzone.h
+++ b/src/soc/samsung/exynos5250/include/soc/trustzone.h
@@ -16,6 +16,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_TRUSTZONE_H
 #define CPU_SAMSUNG_EXYNOS5250_TRUSTZONE_H

+#include <commonlib/helpers.h>
 #include <stdint.h>

/* Distance between each Trust Zone PC register set */
diff --git a/src/soc/samsung/exynos5250/include/soc/uart.h b/src/soc/samsung/exynos5250/include/soc/uart.h
index 0f63b01..1c4558f 100644
--- a/src/soc/samsung/exynos5250/include/soc/uart.h
+++ b/src/soc/samsung/exynos5250/include/soc/uart.h
@@ -17,6 +17,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_UART_H
 #define CPU_SAMSUNG_EXYNOS5250_UART_H

+#include <commonlib/helpers.h>
+
 struct s5p_uart {
    unsigned int	ulcon;
    unsigned int	ucon;
diff --git a/src/soc/samsung/exynos5250/include/soc/usb.h b/src/soc/samsung/exynos5250/include/soc/usb.h
index 4a92f28..12f8637 100644
--- a/src/soc/samsung/exynos5250/include/soc/usb.h
+++ b/src/soc/samsung/exynos5250/include/soc/usb.h
@@ -16,6 +16,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5250_USB_H
 #define CPU_SAMSUNG_EXYNOS5250_USB_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

#define CLK_24MHZ               5
diff --git a/src/soc/samsung/exynos5420/i2c.c b/src/soc/samsung/exynos5420/i2c.c
index 4dd9caa..96aa5e6 100644
--- a/src/soc/samsung/exynos5420/i2c.c
+++ b/src/soc/samsung/exynos5420/i2c.c
@@ -14,6 +14,7 @@
  * GNU General Public License for more details.
  */

+#include <commonlib/helpers.h>
 #include <device/mmio.h>
 #include <assert.h>
 #include <console/console.h>
diff --git a/src/soc/samsung/exynos5420/include/soc/clk.h b/src/soc/samsung/exynos5420/include/soc/clk.h
index 08663ff..7aa26c2 100644
--- a/src/soc/samsung/exynos5420/include/soc/clk.h
+++ b/src/soc/samsung/exynos5420/include/soc/clk.h
@@ -17,6 +17,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_CLK_H
 #define CPU_SAMSUNG_EXYNOS5420_CLK_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>
 #include <soc/dmc.h>
 #include <soc/pinmux.h>
diff --git a/src/soc/samsung/exynos5420/include/soc/dmc.h b/src/soc/samsung/exynos5420/include/soc/dmc.h
index e068255..096604c 100644
--- a/src/soc/samsung/exynos5420/include/soc/dmc.h
+++ b/src/soc/samsung/exynos5420/include/soc/dmc.h
@@ -14,6 +14,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_DMC_H
 #define CPU_SAMSUNG_EXYNOS5420_DMC_H

+#include <commonlib/helpers.h>
+
 #define DMC_INTERLEAVE_SIZE		0x1f

#define PAD_RETENTION_DRAM_COREBLK_VAL	0x10000000
diff --git a/src/soc/samsung/exynos5420/include/soc/dp.h b/src/soc/samsung/exynos5420/include/soc/dp.h
index 6b33a76..e3cc602 100644
--- a/src/soc/samsung/exynos5420/include/soc/dp.h
+++ b/src/soc/samsung/exynos5420/include/soc/dp.h
@@ -19,6 +19,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_DP_H
 #define CPU_SAMSUNG_EXYNOS5420_DP_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* DSIM register map */
diff --git a/src/soc/samsung/exynos5420/include/soc/dsim.h b/src/soc/samsung/exynos5420/include/soc/dsim.h
index 2d6a0c5..8cf1d39 100644
--- a/src/soc/samsung/exynos5420/include/soc/dsim.h
+++ b/src/soc/samsung/exynos5420/include/soc/dsim.h
@@ -18,6 +18,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_DSIM_H
 #define CPU_SAMSUNG_EXYNOS5420_DSIM_H

+#include <commonlib/helpers.h>
+
 /* DSIM register map */
 struct exynos5_dsim {
    unsigned int status;
diff --git a/src/soc/samsung/exynos5420/include/soc/fimd.h b/src/soc/samsung/exynos5420/include/soc/fimd.h
index 3e9d6a4..197c968 100644
--- a/src/soc/samsung/exynos5420/include/soc/fimd.h
+++ b/src/soc/samsung/exynos5420/include/soc/fimd.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_FIMD_H
 #define CPU_SAMSUNG_EXYNOS5420_FIMD_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* FIMD register map */
diff --git a/src/soc/samsung/exynos5420/include/soc/power.h b/src/soc/samsung/exynos5420/include/soc/power.h
index 9b56fe5..b5cc588 100644
--- a/src/soc/samsung/exynos5420/include/soc/power.h
+++ b/src/soc/samsung/exynos5420/include/soc/power.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_POWER_H
 #define CPU_SAMSUNG_EXYNOS5420_POWER_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* Enable HW thermal trip with PS_HOLD_CONTROL register ENABLE_HW_TRIP bit */
diff --git a/src/soc/samsung/exynos5420/include/soc/spi.h b/src/soc/samsung/exynos5420/include/soc/spi.h
index 9d51914..c8a7d4f 100644
--- a/src/soc/samsung/exynos5420/include/soc/spi.h
+++ b/src/soc/samsung/exynos5420/include/soc/spi.h
@@ -17,6 +17,7 @@
 #define CPU_SAMSUNG_EXYNOS5420_SPI_H

#include <boot_device.h>
+#include <commonlib/helpers.h>

/* SPI peripheral register map; padded to 64KB */
 struct exynos_spi {
diff --git a/src/soc/samsung/exynos5420/include/soc/sysreg.h b/src/soc/samsung/exynos5420/include/soc/sysreg.h
index 6417dfb..f7022fa 100644
--- a/src/soc/samsung/exynos5420/include/soc/sysreg.h
+++ b/src/soc/samsung/exynos5420/include/soc/sysreg.h
@@ -18,6 +18,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_SYSREG_H
 #define CPU_SAMSUNG_EXYNOS5420_SYSREG_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

/* sysreg map */
diff --git a/src/soc/samsung/exynos5420/include/soc/tmu.h b/src/soc/samsung/exynos5420/include/soc/tmu.h
index eade11f..5396a7f 100644
--- a/src/soc/samsung/exynos5420/include/soc/tmu.h
+++ b/src/soc/samsung/exynos5420/include/soc/tmu.h
@@ -18,6 +18,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_TMU_H
 #define CPU_SAMSUNG_EXYNOS5420_TMU_H

+#include <commonlib/helpers.h>
+
 struct tmu_reg {
    unsigned int triminfo;
    unsigned int rsvd1;
diff --git a/src/soc/samsung/exynos5420/include/soc/trustzone.h b/src/soc/samsung/exynos5420/include/soc/trustzone.h
index c195cb8..78da110 100644
--- a/src/soc/samsung/exynos5420/include/soc/trustzone.h
+++ b/src/soc/samsung/exynos5420/include/soc/trustzone.h
@@ -16,6 +16,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_TRUSTZONE_H
 #define CPU_SAMSUNG_EXYNOS5420_TRUSTZONE_H

+#include <commonlib/helpers.h>
 #include <stdint.h>

/* Distance between each Trust Zone PC register set */
diff --git a/src/soc/samsung/exynos5420/include/soc/uart.h b/src/soc/samsung/exynos5420/include/soc/uart.h
index 647b1f1..c035af7 100644
--- a/src/soc/samsung/exynos5420/include/soc/uart.h
+++ b/src/soc/samsung/exynos5420/include/soc/uart.h
@@ -17,6 +17,8 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_UART_H
 #define CPU_SAMSUNG_EXYNOS5420_UART_H

+#include <commonlib/helpers.h>
+
 struct s5p_uart {
    unsigned int	ulcon;
    unsigned int	ucon;
diff --git a/src/soc/samsung/exynos5420/include/soc/usb.h b/src/soc/samsung/exynos5420/include/soc/usb.h
index d80857c..2ffe513 100644
--- a/src/soc/samsung/exynos5420/include/soc/usb.h
+++ b/src/soc/samsung/exynos5420/include/soc/usb.h
@@ -16,6 +16,7 @@
 #ifndef CPU_SAMSUNG_EXYNOS5420_USB_H
 #define CPU_SAMSUNG_EXYNOS5420_USB_H

+#include <commonlib/helpers.h>
 #include <soc/cpu.h>

#define CLK_24MHZ               5

Change in coreboot[master]: src (part 1): Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37415

to look at the new patch set (#3).

Change subject: src (part 1): Add missing 'include <commonlib/helpers.h>'
......................................................................

src (part 1): Add missing 'include <commonlib/helpers.h>'

"check_member(structure, member, offset)" needs '<commonlib/helpers.h>'.

Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/uart/pl011.h
M src/soc/cavium/cn81xx/include/soc/soc.h
M src/soc/cavium/cn81xx/spi.c
M src/soc/cavium/cn81xx/timer.c
M src/soc/cavium/cn81xx/uart.c
M src/soc/mediatek/common/include/soc/ddp_common.h
M src/soc/mediatek/common/include/soc/dsi_common.h
M src/soc/mediatek/common/include/soc/gpio_common.h
M src/soc/mediatek/common/include/soc/i2c_common.h
M src/soc/mediatek/common/include/soc/timer.h
M src/soc/mediatek/common/include/soc/usb_common.h
M src/soc/mediatek/mt8173/include/soc/ddp.h
M src/soc/mediatek/mt8173/include/soc/dramc_register.h
M src/soc/mediatek/mt8173/include/soc/dsi.h
M src/soc/mediatek/mt8173/include/soc/flash_controller.h
M src/soc/mediatek/mt8173/include/soc/gpio.h
M src/soc/mediatek/mt8173/include/soc/i2c.h
M src/soc/mediatek/mt8173/include/soc/infracfg.h
M src/soc/mediatek/mt8173/include/soc/mcucfg.h
M src/soc/mediatek/mt8173/include/soc/mipi.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8173/include/soc/spi.h
M src/soc/mediatek/mt8173/include/soc/spm.h
M src/soc/mediatek/mt8173/include/soc/usb.h
M src/soc/mediatek/mt8183/include/soc/ddp.h
M src/soc/mediatek/mt8183/include/soc/dramc_register.h
M src/soc/mediatek/mt8183/include/soc/dsi.h
M src/soc/mediatek/mt8183/include/soc/efuse.h
M src/soc/mediatek/mt8183/include/soc/gpio.h
M src/soc/mediatek/mt8183/include/soc/i2c.h
M src/soc/mediatek/mt8183/include/soc/infracfg.h
M src/soc/mediatek/mt8183/include/soc/mcucfg.h
M src/soc/mediatek/mt8183/include/soc/pll.h
M src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8183/include/soc/smi.h
M src/soc/mediatek/mt8183/include/soc/spi.h
M src/soc/mediatek/mt8183/include/soc/spm.h
M src/soc/mediatek/mt8183/include/soc/usb.h
M src/soc/nvidia/tegra/dc.h
M src/soc/nvidia/tegra/i2c.h
M src/soc/nvidia/tegra/usb.c
M src/soc/nvidia/tegra124/include/soc/clk_rst.h
M src/soc/nvidia/tegra124/include/soc/dma.h
M src/soc/nvidia/tegra124/include/soc/emc.h
M src/soc/nvidia/tegra124/include/soc/flow.h
M src/soc/nvidia/tegra124/include/soc/mc.h
M src/soc/nvidia/tegra124/include/soc/pmc.h
M src/soc/nvidia/tegra124/include/soc/sdram_param.h
M src/soc/nvidia/tegra124/include/soc/spi.h
M src/soc/nvidia/tegra124/include/soc/sysctr.h
M src/soc/nvidia/tegra210/include/soc/clk_rst.h
M src/soc/nvidia/tegra210/include/soc/clst_clk.h
M src/soc/nvidia/tegra210/include/soc/dma.h
M src/soc/nvidia/tegra210/include/soc/emc.h
M src/soc/nvidia/tegra210/include/soc/flow.h
M src/soc/nvidia/tegra210/include/soc/mc.h
M src/soc/nvidia/tegra210/include/soc/pmc.h
M src/soc/nvidia/tegra210/include/soc/sdram_param.h
M src/soc/nvidia/tegra210/include/soc/spi.h
M src/soc/nvidia/tegra210/include/soc/sysctr.h
M src/soc/qualcomm/ipq806x/usb.c
M src/soc/qualcomm/qcs405/usb.c
M src/soc/qualcomm/sdm845/include/soc/clock.h
M src/soc/qualcomm/sdm845/include/soc/efuse.h
M src/soc/qualcomm/sdm845/include/soc/qspi.h
M src/soc/qualcomm/sdm845/usb.c
M src/soc/rockchip/common/include/soc/edp.h
M src/soc/rockchip/common/include/soc/gpio.h
M src/soc/rockchip/common/include/soc/spi.h
M src/soc/rockchip/common/include/soc/vop.h
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/clock.c
M src/soc/rockchip/rk3288/crypto.c
M src/soc/rockchip/rk3288/include/soc/grf.h
M src/soc/rockchip/rk3288/include/soc/hdmi.h
M src/soc/rockchip/rk3288/include/soc/pmu.h
M src/soc/rockchip/rk3288/include/soc/sdram.h
M src/soc/rockchip/rk3288/sdram.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/include/soc/clock.h
M src/soc/rockchip/rk3399/include/soc/grf.h
M src/soc/rockchip/rk3399/include/soc/mipi.h
M src/soc/rockchip/rk3399/include/soc/usb.h
M src/soc/rockchip/rk3399/saradc.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/include/soc/clk.h
M src/soc/samsung/exynos5250/include/soc/dmc.h
M src/soc/samsung/exynos5250/include/soc/dp.h
M src/soc/samsung/exynos5250/include/soc/dsim.h
M src/soc/samsung/exynos5250/include/soc/fimd.h
M src/soc/samsung/exynos5250/include/soc/power.h
M src/soc/samsung/exynos5250/include/soc/spi.h
M src/soc/samsung/exynos5250/include/soc/sysreg.h
M src/soc/samsung/exynos5250/include/soc/tmu.h
M src/soc/samsung/exynos5250/include/soc/trustzone.h
M src/soc/samsung/exynos5250/include/soc/uart.h
M src/soc/samsung/exynos5250/include/soc/usb.h
M src/soc/samsung/exynos5420/i2c.c
M src/soc/samsung/exynos5420/include/soc/clk.h
M src/soc/samsung/exynos5420/include/soc/dmc.h
M src/soc/samsung/exynos5420/include/soc/dp.h
M src/soc/samsung/exynos5420/include/soc/dsim.h
M src/soc/samsung/exynos5420/include/soc/fimd.h
M src/soc/samsung/exynos5420/include/soc/power.h
M src/soc/samsung/exynos5420/include/soc/spi.h
M src/soc/samsung/exynos5420/include/soc/sysreg.h
M src/soc/samsung/exynos5420/include/soc/tmu.h
M src/soc/samsung/exynos5420/include/soc/trustzone.h
M src/soc/samsung/exynos5420/include/soc/uart.h
M src/soc/samsung/exynos5420/include/soc/usb.h
111 files changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37415/3

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37415

to look at the new patch set (#4).

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

src: (part 1) Add missing 'include <commonlib/helpers.h>'

"check_member(structure, member, offset)" needs '<commonlib/helpers.h>'.

Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Signed-off-by: Elyes HAOUAS 
---
M src/drivers/uart/pl011.h
M src/soc/cavium/cn81xx/include/soc/soc.h
M src/soc/cavium/cn81xx/spi.c
M src/soc/cavium/cn81xx/timer.c
M src/soc/cavium/cn81xx/uart.c
M src/soc/mediatek/common/include/soc/ddp_common.h
M src/soc/mediatek/common/include/soc/dsi_common.h
M src/soc/mediatek/common/include/soc/gpio_common.h
M src/soc/mediatek/common/include/soc/i2c_common.h
M src/soc/mediatek/common/include/soc/timer.h
M src/soc/mediatek/common/include/soc/usb_common.h
M src/soc/mediatek/mt8173/include/soc/ddp.h
M src/soc/mediatek/mt8173/include/soc/dramc_register.h
M src/soc/mediatek/mt8173/include/soc/dsi.h
M src/soc/mediatek/mt8173/include/soc/flash_controller.h
M src/soc/mediatek/mt8173/include/soc/gpio.h
M src/soc/mediatek/mt8173/include/soc/i2c.h
M src/soc/mediatek/mt8173/include/soc/infracfg.h
M src/soc/mediatek/mt8173/include/soc/mcucfg.h
M src/soc/mediatek/mt8173/include/soc/mipi.h
M src/soc/mediatek/mt8173/include/soc/pll.h
M src/soc/mediatek/mt8173/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8173/include/soc/spi.h
M src/soc/mediatek/mt8173/include/soc/spm.h
M src/soc/mediatek/mt8173/include/soc/usb.h
M src/soc/mediatek/mt8183/include/soc/ddp.h
M src/soc/mediatek/mt8183/include/soc/dramc_register.h
M src/soc/mediatek/mt8183/include/soc/dsi.h
M src/soc/mediatek/mt8183/include/soc/efuse.h
M src/soc/mediatek/mt8183/include/soc/gpio.h
M src/soc/mediatek/mt8183/include/soc/i2c.h
M src/soc/mediatek/mt8183/include/soc/infracfg.h
M src/soc/mediatek/mt8183/include/soc/mcucfg.h
M src/soc/mediatek/mt8183/include/soc/pll.h
M src/soc/mediatek/mt8183/include/soc/pmic_wrap.h
M src/soc/mediatek/mt8183/include/soc/smi.h
M src/soc/mediatek/mt8183/include/soc/spi.h
M src/soc/mediatek/mt8183/include/soc/spm.h
M src/soc/mediatek/mt8183/include/soc/usb.h
M src/soc/nvidia/tegra/dc.h
M src/soc/nvidia/tegra/i2c.h
M src/soc/nvidia/tegra/usb.c
M src/soc/nvidia/tegra124/include/soc/clk_rst.h
M src/soc/nvidia/tegra124/include/soc/dma.h
M src/soc/nvidia/tegra124/include/soc/emc.h
M src/soc/nvidia/tegra124/include/soc/flow.h
M src/soc/nvidia/tegra124/include/soc/mc.h
M src/soc/nvidia/tegra124/include/soc/pmc.h
M src/soc/nvidia/tegra124/include/soc/sdram_param.h
M src/soc/nvidia/tegra124/include/soc/spi.h
M src/soc/nvidia/tegra124/include/soc/sysctr.h
M src/soc/nvidia/tegra210/include/soc/clk_rst.h
M src/soc/nvidia/tegra210/include/soc/clst_clk.h
M src/soc/nvidia/tegra210/include/soc/dma.h
M src/soc/nvidia/tegra210/include/soc/emc.h
M src/soc/nvidia/tegra210/include/soc/flow.h
M src/soc/nvidia/tegra210/include/soc/mc.h
M src/soc/nvidia/tegra210/include/soc/pmc.h
M src/soc/nvidia/tegra210/include/soc/sdram_param.h
M src/soc/nvidia/tegra210/include/soc/spi.h
M src/soc/nvidia/tegra210/include/soc/sysctr.h
M src/soc/qualcomm/ipq806x/usb.c
M src/soc/qualcomm/qcs405/usb.c
M src/soc/qualcomm/sdm845/include/soc/clock.h
M src/soc/qualcomm/sdm845/include/soc/efuse.h
M src/soc/qualcomm/sdm845/include/soc/qspi.h
M src/soc/qualcomm/sdm845/usb.c
M src/soc/rockchip/common/include/soc/edp.h
M src/soc/rockchip/common/include/soc/gpio.h
M src/soc/rockchip/common/include/soc/spi.h
M src/soc/rockchip/common/include/soc/vop.h
M src/soc/rockchip/common/pwm.c
M src/soc/rockchip/rk3288/clock.c
M src/soc/rockchip/rk3288/crypto.c
M src/soc/rockchip/rk3288/include/soc/grf.h
M src/soc/rockchip/rk3288/include/soc/hdmi.h
M src/soc/rockchip/rk3288/include/soc/pmu.h
M src/soc/rockchip/rk3288/include/soc/sdram.h
M src/soc/rockchip/rk3288/sdram.c
M src/soc/rockchip/rk3288/tsadc.c
M src/soc/rockchip/rk3399/include/soc/clock.h
M src/soc/rockchip/rk3399/include/soc/grf.h
M src/soc/rockchip/rk3399/include/soc/mipi.h
M src/soc/rockchip/rk3399/include/soc/usb.h
M src/soc/rockchip/rk3399/saradc.c
M src/soc/rockchip/rk3399/tsadc.c
M src/soc/samsung/exynos5250/include/soc/clk.h
M src/soc/samsung/exynos5250/include/soc/dmc.h
M src/soc/samsung/exynos5250/include/soc/dp.h
M src/soc/samsung/exynos5250/include/soc/dsim.h
M src/soc/samsung/exynos5250/include/soc/fimd.h
M src/soc/samsung/exynos5250/include/soc/power.h
M src/soc/samsung/exynos5250/include/soc/spi.h
M src/soc/samsung/exynos5250/include/soc/sysreg.h
M src/soc/samsung/exynos5250/include/soc/tmu.h
M src/soc/samsung/exynos5250/include/soc/trustzone.h
M src/soc/samsung/exynos5250/include/soc/uart.h
M src/soc/samsung/exynos5250/include/soc/usb.h
M src/soc/samsung/exynos5420/i2c.c
M src/soc/samsung/exynos5420/include/soc/clk.h
M src/soc/samsung/exynos5420/include/soc/dmc.h
M src/soc/samsung/exynos5420/include/soc/dp.h
M src/soc/samsung/exynos5420/include/soc/dsim.h
M src/soc/samsung/exynos5420/include/soc/fimd.h
M src/soc/samsung/exynos5420/include/soc/power.h
M src/soc/samsung/exynos5420/include/soc/spi.h
M src/soc/samsung/exynos5420/include/soc/sysreg.h
M src/soc/samsung/exynos5420/include/soc/tmu.h
M src/soc/samsung/exynos5420/include/soc/trustzone.h
M src/soc/samsung/exynos5420/include/soc/uart.h
M src/soc/samsung/exynos5420/include/soc/usb.h
111 files changed, 130 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37415/4

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Patch Set 4: Code-Review-1

Isn't <commonlib/helpers.h> chain-included via <types.h>? I think that should be enough. We shouldn't need to encode every detail of where common utility stuff comes from (which changes on occasion) in every file.

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Patch Set 4: Code-Review-1
> Patch Set 4: Code-Review-1
>
> Isn't <commonlib/helpers.h> chain-included via <types.h>? I think that should be enough. We shouldn't need to encode every detail of where common utility stuff comes from (which changes on occasion) in every file.

it is included via <stddef.h>.
the idea is to set <stddef.h> providing only standards.
maybe it is a bad idea, at least, it needs a lot of work and time for review.

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Patch Set 4:
> > Isn't <commonlib/helpers.h> chain-included via <types.h>? I think that should be enough. We shouldn't need to encode every detail of where common utility stuff comes from (which changes on occasion) in every file.
>
> it is included via <stddef.h>.
> the idea is to set <stddef.h> providing only standards.
> maybe it is a bad idea, at least, it needs a lot of work and time for review.

Alternatively, move the `helpers.h` include into `types.h`? That should
properly reflect the intentions:

1. `stddef.h` only provides standard functions,
2. `types.h` gathers several includes for convenience.

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Patch Set 4:
> Alternatively, move the `helpers.h` include into `types.h`? That should
> properly reflect the intentions:
> `stddef.h` only provides standard functions,
> `types.h` gathers several includes for convenience.

Yeah, I'd be fine with that. I just want to avoid every single file having to include a dozen individual headers for all this general toolkit stuff.

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Abandoned

Change in coreboot[master]: src: (part 1) Add missing 'include <commonlib/helpers.h>'

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: src: (part 1) Add missing 'include <commonlib/helpers.h>'
......................................................................

Restored

Change in coreboot[master]: include: Move <commonlib/helpers.h> from <stddef.h> to <types.h>

[HAOUAS Elyes (Code Review)]

Hello Aaron Durbin, Julius Werner, build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37415

to look at the new patch set (#5).

Change subject: include: Move <commonlib/helpers.h> from <stddef.h> to <types.h>
......................................................................

include: Move <commonlib/helpers.h> from <stddef.h> to <types.h>

Change-Id: I1ca717f4b980020e80ac39ea46b430b72848963d
Signed-off-by: Elyes HAOUAS 
---
M src/include/stddef.h
M src/include/types.h
2 files changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37415/5

Change in coreboot[master]: [TODO]: Move <commonlib/helpers.h> from <stddef.h> to <types.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: [TODO]: Move <commonlib/helpers.h> from <stddef.h> to <types.h>
......................................................................

Patch Set 7:

This change is ready for review.

Change in coreboot[master]: [TODO]: Move <commonlib/helpers.h> from <stddef.h> to <types.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37415 )

Change subject: [TODO]: Move <commonlib/helpers.h> from <stddef.h> to <types.h>
......................................................................

Abandoned

vboot/firmware/2lib/include need fix. I'll not touch it