Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin, EricR Lai. leeweitse_seven has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51971 )
Change subject: src/drivers/generic/nau8315: Add nau8315 support ......................................................................
Patch Set 4:
(5 comments)
File src/drivers/generic/nau8315/chip.h:
https://review.coreboot.org/c/coreboot/+/51971/comment/b3046021_372ee6ec PS1, Line 8: const char *hid;
And I think we can fixed the HID name. Since kernel driver only look up specific name.
Done
https://review.coreboot.org/c/coreboot/+/51971/comment/8cb87951_d6d2eaad PS1, Line 13: /* GPIO used to indicate if this device is present */
I think we can remove this. We can have FW config for present now.
Done
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/51971/comment/6cea25a7_104ae3eb PS1, Line 11: #if CONFIG(HAVE_ACPI_TABLES)
use depend for it. please refer my CL. https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/51971/comment/eb46cdf7_19d3f0c7 PS1, Line 53: enable-gpio
enable-gpios
Done
File src/drivers/generic/nau8315/nau8315.c:
https://review.coreboot.org/c/coreboot/+/51971/comment/029de2c6_f6f5a258 PS3, Line 58: return NAU8315_ACPI_NAME;
we can return string here, remove the define.
Done
-
leeweitse_seven (Code Review)