Attention is currently required from: Mac Chiang, leeweitse_seven, Martin Roth, Furquan Shaikh, Tim Wawrzynczak, John Hsu, David Lin, EricR Lai.
View Change
5 comments:
File src/drivers/generic/nau8315/chip.h:
Patch Set #1, Line 8: const char *hid;
And I think we can fixed the HID name. Since kernel driver only look up specific name.
Done
Patch Set #1, Line 13: /* GPIO used to indicate if this device is present */
I think we can remove this. We can have FW config for present now.
Done
File src/drivers/generic/nau8315/nau8315.c:
File src/drivers/generic/nau8315/nau8315.c:
To view, visit change 51971. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie883d65ced3cd95fe318ba0914ed806ff592258d
Gerrit-Change-Number: 51971
Gerrit-PatchSet: 4
Gerrit-Owner: leeweitse_seven <scott.6986@hotmail.com>
Gerrit-Reviewer: David Lin <CTLIN0@nuvoton.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: John Hsu <KCHSU0@nuvoton.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang@intel.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Mac Chiang <mac.chiang@intel.com>
Gerrit-Attention: leeweitse_seven <scott.6986@hotmail.com>
Gerrit-Attention: Martin Roth <martinroth@google.com>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: John Hsu <KCHSU0@nuvoton.com>
Gerrit-Attention: David Lin <CTLIN0@nuvoton.com>
Gerrit-Attention: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Apr 2021 06:46:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-MessageType: comment