Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24905 )
Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot. ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/Kconfig File src/drivers/tpm/Kconfig:
https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/Kconfig@4 PS3, Line 4: depends on !VBOOT
Could you please add some documentation here explaining what the purpose of this config is?
Ack
https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/tpm.c File src/drivers/tpm/tpm.c:
https://review.coreboot.org/#/c/24905/3/src/drivers/tpm/tpm.c@21 PS3, Line 21: #include <security/tpm/tspi.h>
Doesn't seem all these #includes are necessary.
Ack