Attention is currently required from: Eran Mitrani, Ivy Jian, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71221?usp=email )
Change subject: mb/google/rex/var/rex0: Toggle NVMe PWR pin to reset SSD
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71221/comment/0eb9986e_808356b0 :
PS3, Line 7: mb/google/rex: toggling NVMe PWR pin to reset SSD
Please use imperative mood: Toggle …
Thanks for comments. The commit message is updated.
https://review.coreboot.org/c/coreboot/+/71221/comment/91eaac26_a9b5c8be :
PS3, Line 11: as early stage
as in early stage
Thanks for comments. The commit message is updated.
https://review.coreboot.org/c/coreboot/+/71221/comment/7d10dabb_ca209797 :
PS3, Line 15: TEST= Try reboot from OS console and check boot to OS again
What variant and what NVMe disk?
Thanks for comments. The commit message is updated. Please let us know if you see any issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71221?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f34e3f49e7fc388198ff85c8e119cb3f242a60e
Gerrit-Change-Number: 71221
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Sun, 15 Oct 2023 09:03:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment