Change in coreboot[master]: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

2 Oct 2020 2 Oct '20

9:08 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers

Scan bridge devices like I2C Mutiplexers behind I2C controllers using scan_static_bus.

BUG=b:169444894 TEST=Build and boot waddledee to OS. Ensure that all the bridge devices behind I2C controller are scanned and enabled.

Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/soc/intel/common/block/i2c/i2c.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/45949/1

diff --git a/src/soc/intel/common/block/i2c/i2c.c b/src/soc/intel/common/block/i2c/i2c.c index 0de3bd3..5aa7729 100644 --- a/src/soc/intel/common/block/i2c/i2c.c +++ b/src/soc/intel/common/block/i2c/i2c.c @@ -166,7 +166,7 @@ .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, - .scan_bus = scan_smbus, + .scan_bus = scan_static_bus, .ops_i2c_bus = &dw_i2c_bus_ops, .ops_pci = &pci_dev_ops_pci, .init = dw_i2c_device_init,

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Furquan Shaikh (Code Review)

5 Oct 5 Oct

10:23 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45949/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45949/2//COMMIT_MSG@9 PS2, Line 9: Scan bridge devices like I2C Mutiplexers behind I2C controllers using I think it would be good to provide some context in commit message that the original assumption was that there will only be non-bridge devices under the SoC I2C controller and hence it was using scan_generic_bus. However, we need to support I2C Multiplexers which act as bridges and have devices under them. That is why the change to scan_static_bus is required.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 05 Oct 2020 20:23:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8 Oct 8 Oct

9:19 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Evan Green, Tim Wawrzynczak, Duncan Laurie, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45949

to look at the new patch set (#3).

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers

Currently devices behind I2C controllers are scanned using scan_smbus. This is done under the assumption that there are no bridge devices behind I2C controllers. In order to support I2C multiplexers which act as bridge devices and have devices behind them, scan the I2C controllers using scan_static_bus.

BUG=b:169444894 TEST=Build and boot waddledee to OS. Ensure that all the bridge devices behind I2C controller are scanned and enabled.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/45949/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

9:19 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45949/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45949/2//COMMIT_MSG@9 PS2, Line 9: Scan bridge devices like I2C Mutiplexers behind I2C controllers using

...

I think it would be good to provide some context in commit message that the original assumption was […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 07:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

8:09 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 18:09:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:14 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 08 Oct 2020 18:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

12 Oct 12 Oct

10:47 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45949 )

Change subject: soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers ......................................................................

soc/intel/common/block/i2c: Scan bridge devices behind I2C controllers

BUG=b:169444894 TEST=Build and boot waddledee to OS. Ensure that all the bridge devices behind I2C controller are scanned and enabled.

Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45949 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/i2c/i2c.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/45949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab Gerrit-Change-Number: 45949 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Evan Green evgreen@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1556

days inactive

1566

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Tim Wawrzynczak (Code Review)