Patch set 2:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9: Scan bridge devices like I2C Mutiplexers behind I2C controllers using
I think it would be good to provide some context in commit message that the original assumption was that there will only be non-bridge devices under the SoC I2C controller and hence it was using scan_generic_bus. However, we need to support I2C Multiplexers which act as bridges and have devices under them. That is why the change to scan_static_bus is required.
To view, visit change 45949. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d8159a507683d8c56dd5e59d20c30ed7e4b2cab
Gerrit-Change-Number: 45949
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Evan Green <evgreen@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Justin TerAvest <teravest@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 05 Oct 2020 20:23:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment