build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55128 )
Change subject: src/mainboard: Add Star Labs labtop series ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/starlabs/labtop/ramstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120482): https://review.coreboot.org/c/coreboot/+/55128/comment/6e4e313f_7ebd4c6f PS1, Line 11: void mainboard_silicon_init_params(FSPS_UPD *supd) need consistent spacing around '*' (ctx:WxV)
File src/mainboard/starlabs/labtop/variants/cml/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120482): https://review.coreboot.org/c/coreboot/+/55128/comment/f5e3b10e_dfcc1a82 PS1, Line 114: const uint8_t ht = get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading); line over 96 characters