Francois Toguo Fotso has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table ......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10: The Key here is understanding the picture I provided to see how the raw data concept fully fit into a BERT entry. For example an entry can validly have only raw data and no other data. And in that case raw_data_length = data_length. Still raw_data_length will need to be updated. CB:55006 have been pushed already to remove any dependency you will have in linux on changes from the Intel Crashlog flow. Removing the raw data will unblock you, for now. But once again ignoring that variable is not the best approach; because at some point, any other OEMs might decide to use it and we will be back to square 1 again.
I do not see the need to move the code you suggested from AMD to the common acpi. Intel already has a similar logic in the file below. It was kept at the SOC level because various OEMs might need the flexibility to check what type of data to put in a BERT; as long as the defined format of the ACPI BERT, previously provided, is followed https://review.coreboot.org/c/coreboot/+/49943/17/src/soc/intel/common/block...
-
Francois Toguo Fotso (Code Review)