Change in coreboot[master]: ChromeOS: Use CHROMEOS_NVS guard - coreboot-gerrit

21 Apr 2021


      Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie, Kyösti Mälkki, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50611 )
Change subject: ChromeOS: Use CHROMEOS_NVS guard
......................................................................
Patch Set 6:
(1 comment)
File src/vendorcode/google/chromeos/ramoops.c:
https://review.coreboot.org/c/coreboot/+/50611/comment/fefc12a7_c20a1717 
PS5, Line 41: 	if (CONFIG(CHROMEOS_NVS))
...
We pretty much have defined CHROMEOS_NVS = CHROMEOS && HAVE_ACPI_TABLES. […]
No ACPI on ARM, so no problem here.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50611
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife888ae43093949bb2d3e397565033037396f434
Gerrit-Change-Number: 50611
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie duncan@iceblink.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Duncan Laurie duncan@iceblink.org
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 21 Apr 2021 09:26:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment