Attention is currently required from: Jason Glenesk, Raul Rangel, Matt Papageorge, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54065 )
Change subject: soc/amd/cezanne: adding support for the changed AMD FSP API for USB PHY
......................................................................
Patch Set 7:
(2 comments)
File src/soc/amd/cezanne/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119327):
https://review.coreboot.org/c/coreboot/+/54065/comment/b2e4c198_e1c74749
PS7, Line 131: if (config->usb_phy_custom)
suspect code indent for conditional statements (8, 12)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119327):
https://review.coreboot.org/c/coreboot/+/54065/comment/81e3fa66_c59f0223
PS7, Line 133: else
suspect code indent for conditional statements (8, 12)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I011ca40a334e4fd26778ca7f18b653298b14019b
Gerrit-Change-Number: 54065
Gerrit-PatchSet: 7
Gerrit-Owner: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 14 May 2021 12:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment