Attention is currently required from: Arthur Heymans, Arthur Heymans, Martin L Roth, Matt DeVillier, Nicholas Sudsgaard, Sean Rhodes.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80883?usp=email )
Change subject: payload/external/edk2: Explicitly define the build arch
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
It's just what its built on that matter, not what for. […]
The architecture argument - `-a` - needs be `-a IA32 -a X64` so that the entrypoint is built as 32-bit code. UPL's build script might remap `-D BUILD_ARCH=X64` to this for us, I haven't looked recently.
In general, yeah, it might be good to make the build string more generic: Unless the program runner can handle mode switches, then we can make `-a IA32` conditional on ARCH_RAMSTAGE_X86_32.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80883?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd942d0c15a99231d09f9cbdc5eb48333b6aa6e5
Gerrit-Change-Number: 80883
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 09 Mar 2024 00:24:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-MessageType: comment