Change in ...coreboot[master]: mb/google/sarien: Set ELAN as the default for touch panel
Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31430
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
mb/google/sarien: Set ELAN as the default for touch panel
According to request of comment 35, setting ELAN as the default.
BUG=b:122019253 BRANCH=master TEST=Verify touchscreen on sarien works with this change.
Signed-off-by: Chris Zhou chris_zhou@compal.corp-partner.google.com Change-Id: Iee5e7a21545ca798c0c22f86906acc8e7d81e945 --- M src/mainboard/google/sarien/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/31430/1
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 4aea9f7..a976d36 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -100,7 +100,7 @@ config TOUCHSCREEN_HID string "Specify the touchscreen HID enabled for the OS" default "WCOM48E2" if BOARD_GOOGLE_ARCADA - default "NONE" if BOARD_GOOGLE_SARIEN + default "ELAN900C" if BOARD_GOOGLE_SARIEN
config VBOOT select HAS_RECOVERY_MRC_CACHE
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
Patch Set 1: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
mb/google/sarien: Set ELAN as the default for touch panel
According to request of comment 35, setting ELAN as the default.
BUG=b:122019253 BRANCH=master TEST=Verify touchscreen on sarien works with this change.
Signed-off-by: Chris Zhou chris_zhou@compal.corp-partner.google.com Change-Id: Iee5e7a21545ca798c0c22f86906acc8e7d81e945 Reviewed-on: https://review.coreboot.org/c/31430 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved
diff --git a/src/mainboard/google/sarien/Kconfig b/src/mainboard/google/sarien/Kconfig index 4aea9f7..a976d36 100644 --- a/src/mainboard/google/sarien/Kconfig +++ b/src/mainboard/google/sarien/Kconfig @@ -100,7 +100,7 @@ config TOUCHSCREEN_HID string "Specify the touchscreen HID enabled for the OS" default "WCOM48E2" if BOARD_GOOGLE_ARCADA - default "NONE" if BOARD_GOOGLE_SARIEN + default "ELAN900C" if BOARD_GOOGLE_SARIEN
config VBOOT select HAS_RECOVERY_MRC_CACHE
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
Patch Set 2:
(1 comment)
Please adhere to the 24h rule before merging.
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG@9 PS2, Line 9: According to request of comment 35, setting ELAN as the default. what comment 35???
Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG@9 PS2, Line 9: According to request of comment 35, setting ELAN as the default.
what comment 35???
issue 122019253 comment 35.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG@9 PS2, Line 9: According to request of comment 35, setting ELAN as the default.
issue 122019253 comment 35.
ok, so it is *your* bug tracker. That doesn't tell me, though, how to access it or if I have access at all. Please, do not refer to information in other places in such odd ways. Use URLs if necessary. Don't refer to it if it's not public. In that case, a quote would be appreciated.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31430 )
Change subject: mb/google/sarien: Set ELAN as the default for touch panel ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31430/2//COMMIT_MSG@9 PS2, Line 9: According to request of comment 35, setting ELAN as the default.
ok, so it is *your* bug tracker
Oops, just realized you're not working directly for the cros firmware team. But I suspect it is their bug tracker.
Their bug tracker isn't public but the coreboot project is. So references to these bugs are meaningless for many people in the project.
-
Chris Zhou (Code Review) -
Duncan Laurie (Code Review)
-
Nico Huber (Code Review)