Attention is currently required from: Nicholas Chin.
Julius Werner has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86009?usp=email )
Change subject: util/cbfstool: Remove existing file for add-int command ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1: Thanks!
PS1:
Would this make sense to implement for other `add*` commands?
No, I think add-int is a special case because it's used for these kinds of options, and it's common that you would just want to overwrite the value with something else. The other add commands tend to be used for real binary files, and for those overwriting the old one is less common and more complicated, so I think it makes sense that the removal needs to be explicit there.
-
Julius Werner (Code Review)