Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23648 )
Change subject: google/nautilus: set oem_id oem_table_id fields of acpi_header_t
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23648/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nautilus/nhlt.c:
https://review.coreboot.org/#/c/23648/1/src/mainboard/google/poppy/variants/...
PS1, Line 37: __attribute__((weak))
This shouldn't be a weak function.
--
To view, visit
https://review.coreboot.org/23648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I041f2838f07a2525be7a28fdc69b7f1af46d16f1
Gerrit-Change-Number: 23648
Gerrit-PatchSet: 1
Gerrit-Owner: Naveen Manohar
naveen.m@intel.com
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 08 Feb 2018 04:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No