Attention is currently required from: Tim Wawrzynczak, Michał Kopeć, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62494 )
Change subject: intelblocks/pep: Add display on/off notifications and handle TBT displays ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62494/comment/51133bed_ea56b36c PS3, Line 7: intelblocks/pep: Add display on/off notifications and handle TBT displays
nit: 72 characters wide for commit msgs
Actually, it doesn't fit because this commit does too much. Whenever `and` appears in the commit summary, it's most likely possible to split into multiple commits.
https://review.coreboot.org/c/coreboot/+/62494/comment/abb7c514_e6e993f9 PS3, Line 8: : Add display on and off notifications which call mainboard hooks if : present. This allows to handle some board specific functions in user : absence or presence (whe ndisplay goes off from inactivity or on from : activity). : : Additionally notify IOM to enable or disable TBT displays on S0ix : exit and entry respectively.
These are kind of unrelated changes, mind splitting this into two patches?
+1